updated tests for batch sending #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eccles
previously approved these changes
Jan 2, 2025
added 2 commits
January 2, 2025 14:43
robinbryce
force-pushed
the
dev/robin/9588-batch-builder-receiver
branch
from
c6ffe85 to
7356181
Compare
eccles
previously approved these changes
Jan 2, 2025
|
I have several questions, so hold your horses for a bit please :) |
wp0pw
reviewed
Jan 2, 2025
and remove the conditionality from the original receiver.
robinbryce
commented
Jan 2, 2025
robinbryce
commented
Jan 2, 2025
* remove the private accessors
wp0pw
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change delegates full responsibility for receiving, sending and disposition to tha handler. This is the only way to maximise the benefit of azure batch messaging in an application aware way. See this PR for example use https://github.com/datatrails/forestrie/pull/283
In particular, the serial disposition offered by this PR #64 results in N * 10's of ms per message delay between receives
With application aware disposition it is possible to reduce that to just 10's of ms
AB#9588
application level testing was performed using avid-events and forestrie, results and config posted here https://jitsuin.atlassian.net/wiki/spaces/ENG/pages/3544219652/10068+Performance+Testing?focusedCommentId=3571875842