Skip to content

updated tests for batch sending #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 3, 2025
Merged

updated tests for batch sending #96

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d154b9e
updated tests for batch sending
Dec 27, 2024
7356181
code: quality fixups and rebase for conflicts
Jan 2, 2025
946f566
review: make the batch receiver a distinct type
Jan 2, 2025
002bfce
* make Receiver dispose private again (the batch one remains public)
Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions azbus/disposition.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ const (
CompleteDisposition
)

type Disposer interface {
Dispose(ctx context.Context, d Disposition, err error, msg *ReceivedMessage)
}

func (d Disposition) String() string {
switch {
case d == DeadletterDisposition:
Expand All @@ -34,7 +38,7 @@ func (d Disposition) String() string {
return fmt.Sprintf("Unknown%d", d)
}

func (r *Receiver) dispose(ctx context.Context, d Disposition, err error, msg *ReceivedMessage) {
func (r *Receiver) Dispose(ctx context.Context, d Disposition, err error, msg *ReceivedMessage) {
switch {
case d == DeadletterDisposition:
r.deadLetter(ctx, err, msg)
Expand Down Expand Up @@ -114,7 +118,7 @@ func (r *Receiver) complete(ctx context.Context, err error, msg *ReceivedMessage
if err != nil {
log.Infof("Complete Message %v", err)
} else {
log.Infof("Complete Message")
log.Debugf("Complete Message")
}

err1 := r.receiver.CompleteMessage(ctx, msg, nil)
Expand Down
72 changes: 72 additions & 0 deletions azbus/mocks/BatchHandler.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 36 additions & 0 deletions azbus/mocks/Disposer.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

97 changes: 3 additions & 94 deletions azbus/mocks/Handler.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading