Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add event_time page #6383
base: current
Are you sure you want to change the base?
add event_time page #6383
Changes from 12 commits
46231b0
33a66a8
4f2c6dc
57ee608
3354c9d
603c21c
488460c
2fb62c5
69ba339
1ebbbdb
2b713ee
c789601
5708119
903c5d1
2dd873a
b7a07be
016c555
2910914
79128fe
551821d
735ae38
ac7616b
0363051
d693c9b
809f2a7
81e2318
14632b3
2b98454
3da521f
edd1123
52c0db9
f461ffa
a4f3b23
a1c8166
f1969f4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both of these bullets have the same benefit of "using only the overlapping timeframe, which avoids incorrect row-count changes and returns results faster"
I would distinguish the 2 scenarios as:
Rather than nesting the second scenario within the first - lmk if that makes sense!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed it to this;
It's common for CI jobs to only build a subset of data (for example only the last 7 days of data).
When an
event_time
column is specified on your model, compare changes can optimize comparisons by using only the overlapping timeframe (meaning the timeframe exists in both the CI and production environment), helping you avoid incorrect row-count changes to return results faster.This is useful in scenarios like:
event_time
allows you to avoid this issue by limiting comparisons to the overlapping timeframe, preventing false alerts about data deletions that are just filtered out in CI.event_time
configured, the comparison only includes the shared timeframe and correctly reflects actual changes in the data.