Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increasing UT coverage #346

Draft
wants to merge 60 commits into
base: main
Choose a base branch
from
Draft

Increasing UT coverage #346

wants to merge 60 commits into from
+6,548 −143

Conversation

KshitijaKakde
Copy link

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

KshitijaKakde and others added 30 commits February 12, 2025 00:42
@KshitijaKakde
added UT for utils.go
b623e3c
@karthikk92
Updated provider.go file
54e05f9
@karthikk92
Updated provider.go file
6c80c94
@AkshaySainiDell
Add UT for k8sutils
944f7fb
@AkshaySainiDell
Add UT for k8sutils
e37728d
@KshitijaKakde
added UT for csiutils.go
7c3fb17
@KshitijaKakde
added UT for utils.go
6976cfa
@KshitijaKakde
added UT for utils.go
714e8c9
@WilsonRadadia20
Update UT coverage for semver.go
ea54c33
@sakshi-garg1
Adding UT for k8sutils.go
236b226
@panigs7
add ut for nodeConnectivitiychecker
3c26fe8
@samihan-dell
test: Increased code coverage of controllerNodeToArrayConnectivity.go…
6fc3af6 
… file to 93%
@samihan-dell
t pushMerge branches 'UT-coverage' and 'UT-coverage' of https://githu…
a901000 
…b.com/dell/csi-powerscale into UT-coverage
@samihan-dell
fix: Fixing linting issue
f453f0e
@rajendraindukuri
Updated UT for mount.go file
b0a3e6c
@panigs7
Improve UT Coverage for nodeconnectivitychecker
db40533
@sakshi-garg1
adding more UT for k8sutils (#348)
608d40c 
PR is getting merged to UT-coverage feature branch hence no approval required.
@rishabhatdell
added scenarios to increase UT for csi_extension_server.go
dfe443b
@sakshi-garg1
Increasing UT coverage for service.go
09db0f4
@rajendraindukuri
Updated code coverage for isiService
fb644e3
@atye
test csi-utils
9e3770d
@atye
test k8sutils
0926fdd
@atye
fix csiutils
02e5d01
@atye
more coverage to service
69971d9
@WilsonRadadia20
Increased UT coverage for provider.go
11d73a8
@panigs7
add more UT to service/nodeConnectivityChecker.go
d00006e
@sakshi-garg1
Increase Ut coverage for service.go
51794e9
@panigs7
Code coverage of nodeConnectivityChecker 91.3%
afff24e
@WilsonRadadia20
Fix for the semver.go failure
b5de661
@WilsonRadadia20
Merge branch 'UT-coverage' of https://github.com/dell/csi-powerscale …
c6198f9 
…into UT-coverage
rishabhatdell and others added 30 commits February 17, 2025 08:16
@rishabhatdell
added ut for replication.go
b05598d
@rajendraindukuri
Improved coverage for errror scenarios isiService
1102c87
@sakshi-garg1
Increasing coverage of service.go
60c7795
@rajendraindukuri
Further improved the coverage for isiservice file
682a1af
@chaganti-rajitha
increased coverage for controller.go
a5dfaa3
@karthikk92
Updated main test.go UT
d3f083e
@karthikk92
Updated main test.go UT
7c4b2a2
@samihan-dell
test: Increased test coverage for node.go file
d909061
@samihan-dell
Merge branch 'UT-coverage' of https://github.com/dell/csi-powerscale …
d3a3cbb 
…into UT-coverage
@chaganti-rajitha
increased coverage for controller.go
ac393db
@chaganti-rajitha
added test case in coverage.go
90c228b
@karthikk92
Updated main test.go UT and UT reached to 42.2%
3642f51
@karthikk92
Merge branch 'UT-coverage' of https://github.com/dell/csi-powerscale …
5411134 
…into UT-coverage
@rishabhatdell
fixed race condition
f73f9f9
@samihan-dell
test: Increased test coverage for node.go file
d6253c0
@samihan-dell
Merge branch 'UT-coverage' of https://github.com/dell/csi-powerscale …
08025d1 
…into UT-coverage
@ChristianAtDell
added some service tests
4b165f8
@JacobGros
add replication test WIP, modify client to not return error all time,…
3448fd3 
… fix panic
@sakshi-garg1
Increasing UT for service.go
bba13ca
@suryagupta4
add UT for synchronize and suspend in replication_test.go
1323f86
@chaganti-rajitha
added test cases in coverage.go
e3f9bad
@samihan-dell
refactor: Refactored to include functions mocking in node_test.go
0996ff2
@JacobGros
adding godog tests back to check coverage
6200786
@samihan-dell
test: Added UTs for node.go increases code coverage to 28%
a18824a
@samihan-dell
Merge branch 'UT-coverage' of https://github.com/dell/csi-powerscale …
2239802 
…into UT-coverage
@samihan-dell
testcase name change
a875b3b
@anathoodell
This commit focuses only on main.go uni testing.
756e4a8 
The improvement is the dependency injection for gocsi.Run() which allows
for the unit tests to run a custom Run() function, this solves the main
issue with the failed tests.

The tests with this commit are passing, but most tests are commented
except for "TestMainFunction/LeaderElectionDisabled" and a few others that do
not impact the os.flags of that test. If the other tests are enabled, we end up
with an os.exit due to a flag being redefined, this issue still needs to be sorted to
get all the other tests passing, and then we will need to beef up the
tests to get from 64% which is where we are now to 90%.
@ChristianAtDell
cleaned up some node tests
2b9db8a
@ChristianAtDell
ephemeral node publish tests
cae9f6d
@JacobGros
add more replication UT
a28ba65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atye atye Awaiting requested review from atye atye will be requested when the pull request is marked ready for review atye is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 will be requested when the pull request is marked ready for review bpjain2004 is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain will be requested when the pull request is marked ready for review chimanjain is a code owner

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell ChristianAtDell will be requested when the pull request is marked ready for review ChristianAtDell is a code owner

@donatwork donatwork Awaiting requested review from donatwork donatwork will be requested when the pull request is marked ready for review donatwork is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL will be requested when the pull request is marked ready for review HarishH-DELL is a code owner

@meggm meggm Awaiting requested review from meggm meggm will be requested when the pull request is marked ready for review meggm is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 will be requested when the pull request is marked ready for review nitesh3108 is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 will be requested when the pull request is marked ready for review prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani will be requested when the pull request is marked ready for review rajkumar-palani is a code owner

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell Sakshi-dell will be requested when the pull request is marked ready for review Sakshi-dell is a code owner

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell santhoshatdell will be requested when the pull request is marked ready for review santhoshatdell is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro will be requested when the pull request is marked ready for review shaynafinocchiaro is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra will be requested when the pull request is marked ready for review shefali-malhotra is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.