Skip to content

Increasing UT coverage #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2025
Merged

Increasing UT coverage #346

merged 2 commits into from
Feb 25, 2025

Conversation

@KshitijaKakde
Copy link
Contributor

@KshitijaKakde KshitijaKakde commented Feb 12, 2025 •
edited by suryagupta4
Loading

Description

Increasing UT coverage to 90%

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1726

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

cert-csi sanity:

cert-csi-sanity.txt
image

suryagupta4
suryagupta4 previously approved these changes Feb 25, 2025
View reviewed changes
@karthikk92 karthikk92 marked this pull request as ready for review February 25, 2025 10:43
donatwork
donatwork reviewed Feb 25, 2025
View reviewed changes
@donatwork
Copy link
Contributor

Did you run a quick sanity test to validate that the driver still works?

@suryagupta4
Copy link
Contributor

Did you run a quick sanity test to validate that the driver still works?

Currently running sanity, will post results once done.

@suryagupta4 suryagupta4 merged commit 1bc83a3 into main Feb 25, 2025
6 checks passed
@suryagupta4 suryagupta4 deleted the UT-coverage branch February 25, 2025 12:19
@JacobGros JacobGros mentioned this pull request Aug 25, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atye atye Awaiting requested review from atye

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

@meggm meggm Awaiting requested review from meggm

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

4 more reviewers

@donatwork donatwork donatwork approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@chimanjain chimanjain chimanjain approved these changes

@karthikk92 karthikk92 karthikk92 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KshitijaKakde @donatwork @suryagupta4 @chimanjain @karthikk92