Skip to content

Conversation

@DrakeLin
Copy link
Collaborator

@DrakeLin DrakeLin commented Jan 23, 2026

🥞 Stacked PR

Use this link to review incremental changes.


What changes are proposed in this pull request?

Add APIs in transactions to determining columns to collect statistics on. This includes refactoring expected_stats_schema to output stats_columns as well with shared filtering logic.

How was this change tested?

Existing unit tests and new ones

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 86.11111% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.66%. Comparing base (d4ecc0a) to head (33e131d).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
kernel/src/transaction/mod.rs 61.90% 8 Missing ⚠️
kernel/src/table_configuration.rs 50.00% 5 Missing ⚠️
kernel/src/scan/data_skipping/stats_schema.rs 97.40% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1658    +/-   ##
========================================
  Coverage   84.65%   84.66%            
========================================
  Files         123      124     +1     
  Lines       34109    34527   +418     
  Branches    34109    34527   +418     
========================================
+ Hits        28875    29232   +357     
- Misses       3905     3957    +52     
- Partials     1329     1338     +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DrakeLin DrakeLin changed the title feat: add stats_columns to ParquetHandler + Transaction stats API feat: Transaction stats API Jan 23, 2026
@DrakeLin DrakeLin force-pushed the stack/stats-api branch 2 times, most recently from 15957b5 to aca26f8 Compare January 23, 2026 07:37
@DrakeLin DrakeLin requested review from dengsh12 and nicklan January 23, 2026 07:41
@DrakeLin DrakeLin force-pushed the stack/stats-api branch 5 times, most recently from ba3b18f to 340ac84 Compare January 23, 2026 23:26
@DrakeLin DrakeLin removed the breaking-change Change that require a major version bump label Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant