Skip to content

Conversation

@DrakeLin
Copy link
Collaborator

@DrakeLin DrakeLin commented Jan 23, 2026

🥞 Stacked PR

Use this link to review incremental changes.


What changes are proposed in this pull request?

  • Add stats_columns parameter to write_parquet_file trait
    Engines must know which columns to collect context from

How was this change tested?

Edited tests

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 91.27517% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.68%. Comparing base (bbaef1a) to head (748f85c).

Files with missing lines Patch % Lines
kernel/src/table_configuration.rs 50.00% 5 Missing ⚠️
kernel/src/transaction/mod.rs 76.19% 5 Missing ⚠️
kernel/src/scan/data_skipping/stats_schema.rs 97.40% 1 Missing and 1 partial ⚠️
kernel/src/snapshot.rs 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1668      +/-   ##
==========================================
+ Coverage   84.63%   84.68%   +0.04%     
==========================================
  Files         125      125              
  Lines       34724    34822      +98     
  Branches    34724    34822      +98     
==========================================
+ Hits        29390    29488      +98     
+ Misses       3983     3982       -1     
- Partials     1351     1352       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DrakeLin DrakeLin force-pushed the stack/parquet-handler-stats-col branch from e57501c to bc2bd1f Compare January 23, 2026 07:11
@github-actions github-actions bot added the breaking-change Change that require a major version bump label Jan 23, 2026
@DrakeLin DrakeLin force-pushed the stack/parquet-handler-stats-col branch 2 times, most recently from f510f84 to 8d38b03 Compare January 23, 2026 07:41
@DrakeLin DrakeLin requested review from dengsh12 and nicklan January 23, 2026 07:42
@DrakeLin DrakeLin marked this pull request as ready for review January 23, 2026 07:42
@DrakeLin DrakeLin force-pushed the stack/parquet-handler-stats-col branch 5 times, most recently from 05fad0e to 4aaebc9 Compare January 23, 2026 23:26
@DrakeLin DrakeLin force-pushed the stack/parquet-handler-stats-col branch 2 times, most recently from 19b5957 to 4f68786 Compare January 23, 2026 23:58
- Add stats_columns parameter to write_parquet_file trait
- Add stats_schema(), stats_columns(), get_clustering_columns() to Transaction
- Add stats_columns to WriteContext
- Update get_write_context() to take engine parameter
- Add clustering column support to expected_stats_schema()
@DrakeLin DrakeLin force-pushed the stack/parquet-handler-stats-col branch 2 times, most recently from 748f85c to 2630a7a Compare January 25, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Change that require a major version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant