Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix column name for protocol in P&M query #343

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

OussamaSaoudi-db
Copy link
Collaborator

@OussamaSaoudi-db OussamaSaoudi-db commented Sep 18, 2024

This is a followup to this PR which patches a mistake in the filter. Protocol has a protocol.minReaderVersion, and no protocol.min_reader_version field.

This PR also fixes an intermittent test failure caused by repeat initialization of tracing. This PR changes the test_scan_data test to instead use the test_log crate for initializing logs.

Copy link
Collaborator

@zachschuermann zachschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch thanks

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.03%. Comparing base (1a66fb9) to head (e0ba49a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kernel/src/scan/mod.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
- Coverage   74.08%   74.03%   -0.06%     
==========================================
  Files          43       43              
  Lines        8154     8137      -17     
  Branches     8154     8137      -17     
==========================================
- Hits         6041     6024      -17     
  Misses       1733     1733              
  Partials      380      380              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OussamaSaoudi-db OussamaSaoudi-db merged commit b3a3b7d into delta-io:main Sep 19, 2024
10 of 12 checks passed
@OussamaSaoudi-db OussamaSaoudi-db deleted the pm_followup branch September 19, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants