Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix column name for protocol in P&M query #343

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Fix column name for protocol in P&M query #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b475061
Fix column name for protocol
OussamaSaoudi-db Sep 18, 2024
e0ba49a
Change test logging to use test_log crate
OussamaSaoudi-db Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions kernel/src/scan/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,12 +625,8 @@ mod tests {
);
}

#[test]
#[test_log::test]
fn test_scan_data() {
use tracing_subscriber::EnvFilter;
tracing_subscriber::fmt()
.with_env_filter(EnvFilter::from_default_env())
.init();
let path =
std::fs::canonicalize(PathBuf::from("./tests/data/table-without-dv-small/")).unwrap();
let url = url::Url::from_directory_path(path).unwrap();
Expand Down
2 changes: 1 addition & 1 deletion kernel/src/snapshot.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ impl LogSegment {
use Expression as Expr;
let filter = Some(Expr::or(
Expr::not(Expr::is_null(Expr::column("metaData.id"))),
Expr::not(Expr::is_null(Expr::column("protocol.min_reader_version"))),
Expr::not(Expr::is_null(Expr::column("protocol.minReaderVersion"))),
));
// read the same protocol and metadata schema for both commits and checkpoints
let data_batches = self.replay(engine, schema.clone(), schema, filter)?;
Expand Down
Loading