-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update readme to reflect tracing feature is needed for read-table #619
docs: Update readme to reflect tracing feature is needed for read-table #619
Conversation
The error comes from this line in |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #619 +/- ##
=======================================
Coverage 83.46% 83.46%
=======================================
Files 75 75
Lines 16918 16918
Branches 16918 16918
=======================================
Hits 14120 14120
Misses 2143 2143
Partials 655 655 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugg this is a bit of a mess. thanks for noticing this. So, default-engine
is a "default" feature in the ffi
crate. So you'd have to do --no-default-features
to not get it, and then read-table
would break.
So probably just update the docs to specify that you should enable the tracing feature and remove any mention of the default-engine one for now.
@zachschuermann, let's add this to the list of things we need to fix when we look at feature flags again.
opened an issue for all our feature flag woes #642 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What changes are proposed in this pull request?
Updates the docs to reflect that tracing is required to be enabled in the
read_table.c
example code.How was this change tested?
Compiling without the tracing feature yields the following error:
And compiling with it works.