Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update readme to reflect tracing feature is needed for read-table #619

Merged
merged 5 commits into from
Jan 14, 2025
Merged

docs: Update readme to reflect tracing feature is needed for read-table #619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
864a6f6
Update readme to reflect tracing feature is needed for read-table
OussamaSaoudi-db Jan 3, 2025
8a79246
Update comments
OussamaSaoudi-db Jan 10, 2025
3f55e8d
Add back newline
OussamaSaoudi-db Jan 10, 2025
4ca2f36
Merge branch 'main' into read-table-docs
OussamaSaoudi Jan 10, 2025
86f70c8
Merge branch 'main' into read-table-docs
OussamaSaoudi-db Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ffi/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This crate provides a c foreign function internface (ffi) for delta-kernel-rs.
You can build static and shared-libraries, as well as the include headers by simply running:

```sh
cargo build [--release] [--features default-engine]
cargo build [--release]
```

This will place libraries in the root `target` dir (`../target/[debug,release]` from the directory containing this README), and headers in `../target/ffi-headers`. In that directory there will be a `delta_kernel_ffi.h` file, which is the C header, and a `delta_kernel_ffi.hpp` which is the C++ header.
Expand Down
4 changes: 2 additions & 2 deletions ffi/examples/read-table/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ This example is built with [cmake]. Instructions below assume you start in the d
Note that prior to building these examples you must build `delta_kernel_ffi` (see [the FFI readme] for details). TLDR:
```bash
# from repo root
$ cargo build -p delta_kernel_ffi [--release] [--features default-engine, tracing]
$ cargo build -p delta_kernel_ffi [--release] --features tracing
# from ffi/ dir
$ cargo build [--release] [--features default-engine, tracing]
$ cargo build [--release] --features tracing
```

There are two configurations that can currently be configured in cmake:
Expand Down
Loading