chore: unpin chrono dependency #784
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
breaking-change
Collaborator
|
If arrow-53 didn't pick up the fix, we should probably just keep chrono pinned until we drop that version (either naturally because arrow-55 lands, or because something else forces the upgrade)? |
Collaborator
Author
|
obsolete after #885 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Previously (#719) we pinned chrono to
0.4.39to avoid breaking arrow. Recently, arrow fixed the issue and bumped their own chrono dep to0.4.40(currently the latest) apache/arrow-rs#7198. This PR unpins chrono so we are back on the latest0.4EDIT: looks like the backport fix to arrow 53 only includes the pinning of the chrono version (that is, the PR which fixes/updates chrono isn't in arrow 53) apache/arrow-rs#7231. We can either (1) stop supporting arrow 53 or (2) keep chrono pinned (or perhaps there's a way to pin only for arrow53?)
resolves #721
How was this change tested?
existing