Skip to content

[wip] better #[derive(IntoEngineData)] #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

zachschuermann
Copy link
Collaborator

@zachschuermann zachschuermann commented Apr 19, 2025

stacked on #830

from @scovich - explore possible create_one changes

I guess support for nested structs would require us to derive From for structs, which produces Scalar::Struct? But how do struct scalars interact with create_one that expects leaf values? I almost wonder if we should change create_one to just take a Scalar to extract leaf values from? It comes with a schema and everything, including nullability info, so no need to pass a separate schema.

@github-actions github-actions bot added the breaking-change Change that require a major version bump label Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Change that require a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant