-
Notifications
You must be signed in to change notification settings - Fork 41
feat: include a hash of deno.lock files in the cache key automatically #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not clear to me from the readme that there is a restore key and a cache key, and which parts of the cache key are part of which of these keys.
A cache is not like an artifact, it can be missing or a restored cache that does not match the primary key. The Maybe we can add to the - uses: denoland/setup-deno@v2
id: deno
with:
cache: true
- if: steps.deno.outputs.cache-hit != 'true'
run: deno install Using the restore key from cache should at worst use a cache with some dependencies that are not used, and the |
I'm not sure it's useful for someone to know about this? At a high level (from my understanding), the |
One reason I'm hesitent to add an example doing this, is that |
Yeah, this could indeed be described as an advanced pattern (opt-in). So not promoting it sounds reasonable. The reason I thought including the job-name as part of the cache key is that when not using I think there's pros and cons to both, if every job does |
Sorry if I was annoying just jumping in here with my feedback. Just excited to see build-in action caching landed after #89 being merged. Thought it might be a good idea to upgrade my workflow files first after this PR and hopefully a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My approval doesn't really matter but thought I could chime in since I worked on #89, but looks great to me! Looking forward to this feature! 🎉
Co-authored-by: Christian Svensson <[email protected]>
Co-authored-by: Bartek Iwańczuk <[email protected]>
The `denoland/setup-deno` action recently added built-in caching (denoland/setup-deno#89, denoland/setup-deno#98). This makes it a lot simpler to add caching of the `DENO_DIR` during CI runs, without needing `@actions/cache` manual setup. This should speed up CI runs by avoiding downloading dependencies between every run.
No description provided.