This repository has been archived by the owner on Jul 27, 2018. It is now read-only.
Add secret key generate to travis ci build to support forks #372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
I have…
bin/rails server
) and verified that my changes behave as expected.bin/rubocop
) and vulnerability scan (bin/brakeman
) against my changes.bin/rake spec
) and verified that all tests pass.Summary of Changes
If you want to work with a fork of the project, the build fails for pull requests, most likely due to this limitation. https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions and not having the SECRET_KEY_BASE environment variable set up. This is a small change to the travis build which just generates a secret key base at build time.
Testing
Link with behavior:
before:
https://travis-ci.org/deptofdefense/move.mil/builds/352455122
after:
This pull request should pass testing with no secret key base env var needed in configuration.