arch: Support more platforms #2415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2415 +/- ##
==========================================
- Coverage 86.74% 86.72% -0.03%
==========================================
Files 235 235
Lines 44701 44724 +23
Branches 8288 8293 +5
==========================================
+ Hits 38777 38786 +9
- Misses 5195 5212 +17
+ Partials 729 726 -3 ☔ View full report in Codecov by Sentry. |
FabioLuporini
requested changes
Jul 19, 2024
devito/arch/compiler.py
Outdated
| return super().__getitem__(key) | ||
|
|
||
| def has_key(self, k): | ||
| return k in self.keys() or k.startswith('gcc-') |
There was a problem hiding this comment.
no need for "()" after keys
|
I've also changed the PR title to start with "arch: ..." rather than "compiler: ..." |
georgebisbas
approved these changes
Jul 19, 2024
|
Reinstating Graviton runner so this can actually be tested. |
mloubout
force-pushed
the
graviton
branch
3 times, most recently
from
a5e9828
to
f9b08f0
Compare
ggorman
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalizes gcc
suport graviton 2-3-4 and add cflags to use gcc with it as well