Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch: Support more platforms #2415

Merged
merged 2 commits into from
Jul 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion devito/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def reinit_compiler(val):
# Setup target platform and compiler
configuration.add('platform', 'cpu64', list(platform_registry),
callback=lambda i: platform_registry[i]())
configuration.add('compiler', 'custom', list(compiler_registry),
configuration.add('compiler', 'custom', compiler_registry,
callback=lambda i: compiler_registry[i]())

# Setup language for shared-memory parallelism
Expand Down
21 changes: 19 additions & 2 deletions devito/arch/archinfo.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@
'INTEL64', 'SNB', 'IVB', 'HSW', 'BDW', 'KNL', 'KNL7210',
'SKX', 'KLX', 'CLX', 'CLK', 'SPR',
# ARM CPUs
'AMD', 'ARM', 'AppleArm', 'M1', 'M2', 'M3', 'GRAVITON',
'AMD', 'ARM', 'AppleArm', 'M1', 'M2', 'M3',
'Graviton', 'GRAVITON2', 'GRAVITON3', 'GRAVITON4',
# Other legacy CPUs
'POWER8', 'POWER9',
# Generic GPUs
Expand Down Expand Up @@ -764,6 +765,20 @@ def march(self):
return min(mx, 'm2')


class Graviton(Arm):

@property
def version(self):
return int(self.name.split('graviton')[-1])

@cached_property
def march(self):
if self.version >= 4:
return 'neoverse-n2'
else:
return 'neoverse-n1'


class Amd(Cpu64):

known_isas = ('cpp', 'sse', 'avx', 'avx2')
Expand Down Expand Up @@ -912,7 +927,9 @@ def march(cls):
SPR = IntelGoldenCove('spr') # Sapphire Rapids

ARM = Arm('arm')
GRAVITON = Arm('graviton')
GRAVITON2 = Graviton('graviton2')
GRAVITON3 = Graviton('graviton3')
GRAVITON4 = Graviton('graviton4')
M1 = AppleArm('m1')
M2 = AppleArm('m2')
M3 = AppleArm('m3')
Expand Down
36 changes: 25 additions & 11 deletions devito/arch/compiler.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from codepy.toolchain import (GCCToolchain,
call_capture_output as _call_capture_output)

from devito.arch import (AMDGPUX, Cpu64, AppleArm, NVIDIAX, POWER8, POWER9, GRAVITON,
from devito.arch import (AMDGPUX, Cpu64, AppleArm, NVIDIAX, POWER8, POWER9, Graviton,
IntelDevice, get_nvidia_cc, check_cuda_runtime,
get_m1_llvm_path)
from devito.exceptions import CompilationError
Expand Down Expand Up @@ -434,6 +434,8 @@ def __init_finalize__(self, **kwargs):
if platform in [POWER8, POWER9]:
# -march isn't supported on power architectures, is -mtune needed?
self.cflags = ['-mcpu=native'] + self.cflags
elif isinstance(platform, Graviton):
self.cflags = ['-mcpu=%s' % platform.march] + self.cflags
else:
self.cflags = ['-march=native'] + self.cflags

Expand Down Expand Up @@ -462,8 +464,8 @@ def __init_finalize__(self, **kwargs):
platform = kwargs.pop('platform', configuration['platform'])

# Graviton flag
if platform is GRAVITON:
self.cflags += ['-mcpu=neoverse-n1']
if isinstance(platform, Graviton):
self.cflags += ['-mcpu=%s' % platform.march]


class ClangCompiler(Compiler):
Expand Down Expand Up @@ -962,7 +964,23 @@ def __new_with__(self, **kwargs):
return super().__new_with__(base=self._base, **kwargs)


compiler_registry = {
class CompilerRegistry(dict):
"""
Registry dict for deriving Compiler classes according to the environment variable
DEVITO_ARCH. Developers should add new compiler classes here.
"""

def __getitem__(self, key):
if key.startswith('gcc-'):
i = key.split('-')[1]
return partial(GNUCompiler, suffix=i)
return super().__getitem__(key)

def __contains__(self, k):
return k in self.keys() or k.startswith('gcc-')


_compiler_registry = {
'custom': CustomCompiler,
'gnu': GNUCompiler,
'gcc': GNUCompiler,
Expand All @@ -989,10 +1007,6 @@ def __new_with__(self, **kwargs):
'knl': IntelKNLCompiler,
'dpcpp': DPCPPCompiler,
}
"""
Registry dict for deriving Compiler classes according to the environment variable
DEVITO_ARCH. Developers should add new compiler classes here.
"""
compiler_registry.update({'gcc-%s' % i: partial(GNUCompiler, suffix=i)
for i in ['4.9', '5', '6', '7', '8', '9', '10',
'11', '12', '13']})


compiler_registry = CompilerRegistry(**_compiler_registry)
7 changes: 6 additions & 1 deletion tests/test_arch.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import pytest

from devito.arch.compiler import sniff_compiler_version
from devito.arch.compiler import sniff_compiler_version, compiler_registry


@pytest.mark.parametrize("cc", [
Expand All @@ -10,3 +10,8 @@
def test_sniff_compiler_version(cc):
with pytest.raises(RuntimeError, match=cc):
sniff_compiler_version(cc)


@pytest.mark.parametrize("cc", ['gcc-4.9', 'gcc-11', 'gcc', 'gcc-14', 'gcc-123'])
def test_gcc(cc):
assert cc in compiler_registry
Loading