Skip to content

docs: Revamped GitHub SSO doc #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bharathvaj-p merged 8 commits into from
May 9, 2025
Merged

docs: Revamped GitHub SSO doc #72

bharathvaj-p merged 8 commits into from
May 9, 2025

Conversation

@bharathvaj-p
Copy link
Contributor

@bharathvaj-p bharathvaj-p commented May 5, 2025 •
edited
Loading

@bharathvaj-p bharathvaj-p added the documentation Improvements or additions to documentation label May 5, 2025
@bharathvaj-p bharathvaj-p self-assigned this May 5, 2025
@bharathvaj-p bharathvaj-p marked this pull request as ready for review May 5, 2025 13:31
@bharathvaj-p bharathvaj-p requested review from a team as code owners May 5, 2025 13:31
ashoknayak777
ashoknayak777 requested changes May 6, 2025
View reviewed changes
Copy link
Contributor

@ashoknayak777 ashoknayak777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned a few suggestions we need to incorporate, @bharathvaj-p

ashoknayak777
ashoknayak777 requested changes May 7, 2025
View reviewed changes
Copy link
Contributor

@ashoknayak777 ashoknayak777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iterate the latest suggestions over to GitLab SSO too

@ashoknayak777 ashoknayak777 changed the title docs: Initial draft of GitHub SSO docs: Revamped GitHub SSO doc May 8, 2025
ashoknayak777
ashoknayak777 approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@ashoknayak777 ashoknayak777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

abhibhaw
abhibhaw approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bharathvaj-p bharathvaj-p merged commit 6c462a1 into main May 9, 2025
4 checks passed
@bharathvaj-p bharathvaj-p deleted the github-sso-updation branch May 13, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhibhaw abhibhaw abhibhaw approved these changes

@ashoknayak777 ashoknayak777 ashoknayak777 approved these changes

Assignees

@bharathvaj-p bharathvaj-p

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bharathvaj-p @abhibhaw @ashoknayak777