SMV: use explicit stack for type checking DEFINEs#1624
Merged
tautschnig merged 1 commit intomainfrom Feb 5, 2026
Merged
Conversation
kroening
force-pushed
the
typecheck-defines
branch
2 times, most recently
from
834c45a to
7fbd285
Compare
kroening
force-pushed
the
typecheck-defines
branch
from
7fbd285 to
0610698
Compare
tautschnig
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the recursion for type checking DEFINEs by an explicit
std::stack. This prevents stack overflow when given deep definition chains.This is an alternative to #234 that does not require the construction of an explicit graph.
Closes #17