change Fφ BMC encoding #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
change-Fphi-encoding
branch
3 times, most recently
from
18c4487
to
2a9d18e
Compare
tautschnig
approved these changes
Oct 16, 2024
| @@ -256,6 +256,17 @@ static obligationst property_obligations_rec( | |||
|
|
|||
| obligationst obligations; | |||
|
|
|||
| // Traces with any φ state from "current" onwards satisfy Fφ | |||
| exprt::operandst phi_disjuncts; | |||
There was a problem hiding this comment.
We should make a habit of using .reserve when populating the container via push_back a known quantity of times. It'll take an extra type conversion here to go from mp_integer to std::size_t, but we should avoid the potentially quadratic cost of re-allocating and copying.
kroening
force-pushed
the
change-Fphi-encoding
branch
2 times, most recently
from
3b1c9d0
to
7c134ae
Compare
This changes the word-level BMC encoding for Fφ properties to remove counterexample traces that exhibit the following: 1) a ¬φ loop, 2) followed by one or more φ states. While these traces demonstrate that a counterexample exists (constructed by simply expanding the ¬φ loop), they are not themselves counterexamples to Fφ.
kroening
force-pushed
the
change-Fphi-encoding
branch
from
7c134ae
to
07eefa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the word-level BMC encoding for Fφ properties to remove counterexample traces that exhibit the following:
While these traces demonstrate that a counterexample exists (constructed by simply expanding the ¬φ loop), they are not themselves counterexamples to Fφ.