feat(Accordion): use native <details> element#2190
feat(Accordion): use native <details> element#2190eirikbacker wants to merge 1 commit intodigdir:nextfrom
Conversation
|
|
Welcome back from vacay! Thanks for making this, we'll have a look at this when the rest of the team is back :D Just fyi, I am making some bigger architecture and ci improvements during the summer so things might be broken in next and/or so merge conflicts might arise 😅 |
|
Thanks @mimarz :D |
|
Closed as this will be replaced by #2363 |
- Fixes #2100 🥳 - Deprecates #2176, #2190 - Built on top of `<u-details>` for [better accessibility on mobile](https://u-elements.github.io/u-elements/elements/u-details#accessibility) - Removes `level` from `AccordionHeader` as this is not supported by native `<details>` - Removes `onHeaderClick` from `AccordionHeader` as this is identical to adding a `onClick` handler - JS-based animation can be removed and replaced by CSS when `calc-size(auto)` is fully supported 🚀 - Fixes shrinking chevron on mobile/zoom - Fixes text-align in AccordionHeader on mobile/zoom - Follows: #2295 - Also works in `dir="rtl"` Question: It is now implemented so search-in-page only works when using `defaultOpen`, as a controlled `open` should not be affected by user interaction. Just checking - does this make sense to you guys as well? :)
- Fixes #2100 🥳 - Deprecates #2176, #2190 - Built on top of `<u-details>` for [better accessibility on mobile](https://u-elements.github.io/u-elements/elements/u-details#accessibility) - Removes `level` from `AccordionHeader` as this is not supported by native `<details>` - Removes `onHeaderClick` from `AccordionHeader` as this is identical to adding a `onClick` handler - JS-based animation can be removed and replaced by CSS when `calc-size(auto)` is fully supported 🚀 - Fixes shrinking chevron on mobile/zoom - Fixes text-align in AccordionHeader on mobile/zoom - Follows: #2295 - Also works in `dir="rtl"` Question: It is now implemented so search-in-page only works when using `defaultOpen`, as a controlled `open` should not be affected by user interaction. Just checking - does this make sense to you guys as well? :)
<details>inAccordion#2100 🥳<u-details>for better accessibility on mobilelevelfromAccordionHeaderas this is not supported by native<details>onHeaderClickfromAccordionHeaderas this is identical to adding aonClickhandlercalc-size(auto)is fully supported 🚀dir="rlt"Question: It is now implemented so search-in-page only works when using
defaultOpen, as a controlledopenshould not be affected by user interaction. Just checking - does this make sense to you guys as well? :)