-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Accordion): implement css adjustments and native details #2363
Conversation
|
Preview deployments for this pull request: 📖 Storybook 🖥 Storefront |
Coverage Report
File Coverage
|
Closes #2364 |
Preview deployments for this pull request: Theme |
Preview deployments for this pull request: Theme |
1 similar comment
Preview deployments for this pull request: Theme |
Preview deployments for this pull request: Theme |
<details>
inAccordion
#2100 🥳<u-details>
for better accessibility on mobilelevel
fromAccordionHeader
as this is not supported by native<details>
onHeaderClick
fromAccordionHeader
as this is identical to adding aonClick
handlercalc-size(auto)
is fully supported 🚀dir="rtl"
Question: It is now implemented so search-in-page only works when using
defaultOpen
, as a controlledopen
should not be affected by user interaction. Just checking - does this make sense to you guys as well? :)