Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: errormessage, heading, ingress, label css #2433

Merged
merged 15 commits into from
Sep 23, 2024

Conversation

eirikbacker
Copy link
Contributor

@eirikbacker eirikbacker commented Sep 17, 2024

Copy link

changeset-bot bot commented Sep 17, 2024

⚠️ No Changeset found

Latest commit: d35829e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eirikbacker eirikbacker marked this pull request as draft September 17, 2024 08:04
Copy link
Contributor

github-actions bot commented Sep 17, 2024

Preview deployments for this pull request:

Storybook - 23. Sep 2024 - 13:53

Copy link
Contributor

github-actions bot commented Sep 17, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 62.05% 4264 / 6871
🔵 Statements 62.05% 4264 / 6871
🔵 Functions 85.85% 170 / 198
🔵 Branches 75.66% 572 / 756
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/react/src/components/Typography/Heading/Heading.tsx 100% 100% 100% 100%
packages/react/src/components/Typography/Ingress/Ingress.tsx 37.5% 100% 0% 37.5% 28, 30-37, 39
packages/react/src/components/Typography/Label/Label.tsx 100% 100% 100% 100%
packages/react/src/components/Typography/ValidationMessage/ValidationMessage.tsx 100% 100% 100% 100%
Generated in workflow #586

@eirikbacker eirikbacker marked this pull request as ready for review September 17, 2024 10:32
@eirikbacker eirikbacker marked this pull request as ready for review September 20, 2024 11:18
@eirikbacker eirikbacker merged commit 9a14b6a into next Sep 23, 2024
5 checks passed
@eirikbacker eirikbacker deleted the fix/errormessage-heading-ingress-label-css branch September 23, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants