[CITE-189] Added filter for citation item type #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
jdamerow
requested changes
Mar 23, 2023
| } else { | ||
| query.addCriteria(Criteria.where("itemType").ne(ItemType.NOTE.name()).andOperator( | ||
| Criteria.where("itemType").ne(ItemType.ATTACHMENT.name()), | ||
| Criteria.where("itemType").is(type.name()))); |
There was a problem hiding this comment.
if Criteria.where("itemType").is(type.name()), Criteria.where("itemType").ne(ItemType.NOTE.name()) and Criteria.where("itemType").ne(ItemType.ATTACHMENT.name()) will be true by default.
| } else { | ||
| query.addCriteria(Criteria.where("itemType").ne(ItemType.NOTE.name()).andOperator( | ||
| Criteria.where("itemType").ne(ItemType.ATTACHMENT.name()), | ||
| Criteria.where("itemType").is(type.name()))); |
| List<? extends ICitation> findCitations(String groupId, long start, int pageSize, boolean isDeleted, List<String> conceptIds, String itemType); | ||
|
|
||
| List<? extends ICitation> findCitationsInCollection(String groupId, String collectionId, long start, int pageSize, List<String> conceptIds); | ||
| List<? extends ICitation> findCitationsInCollection(String groupId, String collectionId, long start, int pageSize, List<String> conceptIds, String itemType); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
(you can copy the ticket if it hasn't changed)
https://diging.atlassian.net/browse/CITE-189
...Put description here...
On the citation list page, it should be possible to filter by type.
Anything else the reviewer needs to know?
... describe here ...