Skip to content

Issue #1678: Changes from Claude #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bderenzi
Copy link
Contributor

@bderenzi bderenzi commented Jun 7, 2025

This PR addresses issue #1678

Generated with Claude Code

claude bot and others added 3 commits June 7, 2025 12:20
…imited

- Change display format from space-separated to newline-separated for better readability
- Update parsing logic to split by newlines instead of spaces
- Add automatic stripping of http:// and https:// prefixes from URLs
- Filter out empty lines to prevent invalid domain entries

This improves the user experience when configuring web search tool domain filtering
in pipeline LLM nodes, making it easier to read and manage lists of allowed/blocked domains.

Fixes #1678

Co-authored-by: bderenzi <[email protected]>
Change help text from "Use space to add multiple domains" to "Use newlines 
to add multiple domains" to match the updated frontend implementation that 
now uses newline-delimited instead of space-delimited URL lists for web 
search domain filtering.

Co-authored-by: bderenzi <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@SmittieC SmittieC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a migration as well to migrate existing parameter fields with space delimiters to use newlines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants