Skip to content

Issue #1678: Changes from Claude #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Issue #1678: Changes from Claude #1725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64f69ef
feat: Change URL allow/deny lists from space-delimited to newline-del…
claude[bot] Jun 7, 2025
3162d70
fix: Update help text to reflect newline-delimited URL lists
claude[bot] Jun 7, 2025
4561b9f
Merge remote-tracking branch 'origin/claude/issue-1678-20250607_12174…
bderenzi Jun 7, 2025
4215385
update the help text. Come on claude
bderenzi Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions apps/experiments/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,15 +546,13 @@ def get_tool_configs_by_provider(cls):
"name": "allowed_domains",
"type": "expandable_text",
"label": "Allowed Domains",
"helpText": "Add domains without https from which you want the search results. "
"Use space to add multiple domains",
"helpText": "Only search these domains (e.g. example.com or example.com/blog). Separate entries with newlines.",
},
{
"name": "blocked_domains",
"type": "expandable_text",
"label": "Blocked Domains",
"helpText": "Add domains without https from which you don't want the search results."
" Use space to add multiple domains",
"helpText": "Exclude these domains from search. Separate entries with newlines.",
},
],
}
Expand Down
8 changes: 6 additions & 2 deletions assets/javascript/apps/pipeline/nodes/widgets.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,7 +1033,11 @@ function BuiltInToolsWidget(props: WidgetParams) {
if (!next.data.params.tool_config[toolName]) {
next.data.params.tool_config[toolName] = {};
}
next.data.params.tool_config[toolName][name] = value.split(" ").map(value => value.trim());
next.data.params.tool_config[toolName][name] = value.split("\n").map(url => {
const trimmedUrl = url.trim();
// Strip http:// or https:// prefixes
return trimmedUrl.replace(/^https?:\/\//, '');
}).filter(url => url.length > 0);
}))
}
return (
Expand Down Expand Up @@ -1070,7 +1074,7 @@ function BuiltInToolsWidget(props: WidgetParams) {
name: widget.name,
label: widget.label,
helpText: widget.helpText ?? "",
paramValue: Array.isArray(value) ? value.join(" ") : value,
paramValue: Array.isArray(value) ? value.join("\n") : value,
updateParamValue: (event) => onConfigUpdate(toolKey, event),
inputError: error,
};
Expand Down
Loading