Skip to content

feat: components v2 in builders v1 #10787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 24, 2025

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Mar 2, 2025

Please describe the changes this PR makes and why it should be merged:

The builders version for use in discord.js v14.

Depends on

The changes in the packages discord.js and rest are just needed so the tests don't fail. The target branch is never used for releasing discord.js or @discordjs/rest.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • This PR changes the library's interface (methods or parameters added)

Copy link

vercel bot commented Mar 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2025 7:13pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2025 7:13pm

Copy link

codecov bot commented Mar 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.42%. Comparing base (53dbc96) to head (d75c2dc).
Report is 1 commits behind head on builders/1.x.

Additional details and impacted files
@@               Coverage Diff                @@
##           builders/1.x   #10787      +/-   ##
================================================
+ Coverage         35.44%   37.42%   +1.98%     
================================================
  Files               228      237       +9     
  Lines             14319    14773     +454     
  Branches           1254     1345      +91     
================================================
+ Hits               5075     5529     +454     
  Misses             9200     9200              
  Partials             44       44              
Flag Coverage Δ
brokers 31.44% <ø> (∅)
builders 93.42% <100.00%> (∅)
collection 100.00% <ø> (∅)
formatters 97.43% <ø> (∅)
guide 0.54% <ø> (ø)
proxy 66.27% <ø> (∅)
rest 87.37% <100.00%> (∅)
util 41.42% <ø> (∅)
utilities 100.00% <ø> (∅)
voice 63.64% <ø> (∅)
website 0.00% <ø> (ø)
ws 36.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Qjuh Qjuh marked this pull request as ready for review March 2, 2025 22:53
@Qjuh Qjuh requested review from a team and iCrawl as code owners March 2, 2025 22:53
@Qjuh Qjuh requested review from vladfrangu, kyranet, SpaceEEC, didinele and Jiralite and removed request for a team March 2, 2025 22:53
@Qjuh Qjuh changed the title feat(builders): components v2 in builders v1 feat: components v2 in builders v1 Mar 4, 2025
@Qjuh Qjuh removed the blocked label Mar 8, 2025
@Qjuh Qjuh requested a review from a team as a code owner April 22, 2025 14:42
@Qjuh Qjuh requested review from ckohen and removed request for a team April 22, 2025 14:42
@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Apr 24, 2025
@Qjuh Qjuh merged commit 118e682 into discordjs:builders/1.x Apr 24, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Apr 24, 2025
@Qjuh Qjuh deleted the feat/comp-v2-builders-v1 branch April 24, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants