Fix #10727: Avoid segfault on null strings in std.file.rename (stable… #10769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyberShadow
reviewed
May 1, 2025
0xEAB
pushed a commit
to 0xEAB/phobos
that referenced
this pull request
May 1, 2025
0xEAB
requested changes
May 1, 2025
There was a problem hiding this comment.
Thank you for your work!
Unfortunately, the added unittest is unsuitable to verify the effectiveness of your changes. As demonstrated in #10770 it also passes with the unchanged code currently on ~stable.
Please add a unittest that actually outlines the benefit(s) of your change.
0xEAB
reviewed
May 1, 2025
|
It looks like @Mahipalsinh00 is using an LLM - at least for writing comments (see #10769 (comment)). I'm going to close this PR because:
@Mahipalsinh00 Thank you for submitting the unit test. Please see my comment on a similar contribution here regarding use of LLMs. |
thewilsonator
pushed a commit
that referenced
this pull request
May 3, 2025
Co-authored-by: Parmar Mahipalsinh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10727
Complements #10736 (adds unit tests)