Skip to content

Add unittest from #10769 #10770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025
Merged

Add unittest from #10769 #10770

merged 1 commit into from
May 3, 2025

Conversation

0xEAB
Copy link
Member

@0xEAB 0xEAB commented May 1, 2025

I suspect that this unittest might pass as-is with the current codebase already.

@0xEAB
Copy link
Member Author

0xEAB commented May 1, 2025

#10736 didn’t add a unittest (if I haven’t missed something), so adding this one (copied from #10769) could actually add value.

Copy link
Member

@CyberShadow CyberShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge this and close #10769.

@LightBender
Copy link
Contributor

Bring it out of draft status and I'll merge it.

@0xEAB 0xEAB marked this pull request as ready for review May 3, 2025 18:55
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @0xEAB!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#10770"

@thewilsonator thewilsonator merged commit a819bf6 into dlang:stable May 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants