[WIP] untangling auth-related code #5925
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really (REALLY) work in progress; slowly untangling some of the auth-code which was wrapper-upon-wrapper-upon-wrapper; often because types like
registry.IndexInfo
orregistry.RepositoryInfo
were part of the signature.Docker Content Trust added yet-another layer of abstraction on top of that, with
trust.ImageRefAndAuth
, which is a wrapper on its own to wrap all those bits.In most cases, all we need is;
And of course, there's the "special cases" for docker hub;
docker.io
orindex.docker.io
PREFIX means "docker hub registry" (actual registry isregistry-1.docker.io
(but there's other domains possiblehttps://index.docker.io/v1/
as KEY to store credentials for thoseBut there's more to untangle, such as creds-helpers/stores converting "to hostname", but other paths don't, and likely corner-cases, where (e.g.) a trailing
/
is missing inhttps://index.docker.io/v1/
, etc etc.- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)