cli/command: remove uses of GetAuthConfigKey, ParseRepositoryInfo #5942
+31
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-implement locally, based on the code in github.com/docker/docker/registry, but leaving out bits that are not used on the client-side, such as configuration of Mirrors, and configurable insecure-registry, which are not used on the client side. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
kind/refactor
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #5942 +/- ##
==========================================
- Coverage 59.43% 59.39% -0.04%
==========================================
Files 358 358
Lines 29769 29775 +6
==========================================
- Hits 17694 17686 -8
- Misses 11107 11122 +15
+ Partials 968 967 -1 🚀 New features to boost your workflow:
|
Benehiko
approved these changes
Mar 20, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implement locally, based on the code in github.com/docker/docker/registry, but leaving out bits that are not used on the client-side, such as configuration of Mirrors, and configurable insecure-registry, which are not used on the client side.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)