[release/6.0] Fix WinHttp StreamingTest backward compat version #104838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run runtime-libraries-coreclr outerloop-windows |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
This change is failing on |
This was referenced Jul 13, 2024
|
Template please, definitely before putting in Servicing-approved. |
ManickaP
added
Servicing-consider
liveans
force-pushed
the
fix_winhttp_streamingtest_backward_compat_version_release_6.0
branch
from
b29e9ae
to
f47ef87
Compare
rzikm
approved these changes
Jul 16, 2024
rzikm
changed the title
…kward_compat_version_release_6.0
|
Test only change, CI looks happy, tell mode, adding servicing-approved. |
liveans
added
Servicing-approved
liveans
deleted the
fix_winhttp_streamingtest_backward_compat_version_release_6.0
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #104390
and disables other tests in the same test suite, which can trigger assertion problem see below.
main PR #104722 which fixes the behavior, but in release branches we're disabling tests instead.
Recently, WS2022 got an update which backports AUTOMATIC_CHUNKING in WinHttp, and it affects our test in CI. Because, we were relying on it, now we're disabling tests because #104891 started to pop up with the backport in WS2022.
Customer Impact
No Customer Impact, test-only change.
Regression
No
Testing
CI
Risk
Test-only change, no risk.
Package authoring signed off?
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.