Skip to content

Add docs to breaking change workflow. #120988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2025
Merged

Add docs to breaking change workflow. #120988

merged 1 commit into from
Nov 8, 2025

Conversation

@ericstj
Copy link
Member

@ericstj ericstj commented Oct 22, 2025

No merge, testing a workflow.

@ericstj ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Oct 22, 2025
@dotnet-policy-service dotnet-policy-service bot added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 22, 2025
@ericstj ericstj mentioned this pull request Oct 22, 2025
Open
@ericstj ericstj added needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet and removed needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet labels Oct 22, 2025
@ericstj ericstj changed the title Don't need this thing Test breaking change PR Oct 22, 2025
@ericstj ericstj added needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet and removed needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet labels Oct 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025

📋 Breaking Change Documentation Required

Create a breaking change issue with AI-generated content

Generated by Breaking Change Documentation Tool - 2025-10-24 21:01:08

@ericstj ericstj force-pushed the breakingChangeDocTool-breakstuff branch from c23a8aa to a483925 Compare November 8, 2025 16:13
@ericstj ericstj marked this pull request as ready for review November 8, 2025 16:15
@ericstj ericstj requested a review from jeffhandley as a code owner November 8, 2025 16:15
@ericstj ericstj requested a review from a team as a code owner November 8, 2025 16:15
@ericstj ericstj changed the title Test breaking change PR Add docs to breaking change workflow. Nov 8, 2025
@ericstj
Copy link
Member Author

ericstj commented Nov 8, 2025

To test the workflow I need to merge this. So I've force-pushed it to be a single commit that adds docs to the workflow.

@ericstj ericstj merged commit 34ac620 into dotnet:breakingChangeDocTool Nov 8, 2025
11 of 13 checks passed
@ericstj
Copy link
Member Author

ericstj commented Nov 8, 2025 •
edited
Loading

Workflow was triggered on merge: https://github.com/dotnet/runtime/actions/runs/19195485216

@ericstj ericstj added area-Meta and removed needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet labels Nov 8, 2025
@ericstj
Copy link
Member Author

ericstj commented Nov 8, 2025

Actually, just adding meta was enough to trigger the workflow. I should probably try to change it so that only the addition of the label when closed is enough, otherwise it will be too noisy when applying unrelated labels to a closed PR.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2025

📋 Breaking Change Documentation Required

Create a breaking change issue with AI-generated content

Generated by Breaking Change Documentation Tool - 2025-11-08 16:22:21

@ericstj ericstj added enhancement Product code improvement that does NOT require public API changes/additions needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet labels Nov 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2025

📋 Breaking Change Documentation Required

Create a breaking change issue with AI-generated content

Generated by Breaking Change Documentation Tool - 2025-11-08 22:11:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffhandley jeffhandley Awaiting requested review from jeffhandley jeffhandley is a code owner

Assignees

@ericstj ericstj

Labels

area-Meta breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. enhancement Product code improvement that does NOT require public API changes/additions needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ericstj