Refactor NativeAOT helpers to align with CoreCLR patterns #121158
+225
−285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
Co-authored-by: jkotas <[email protected]>
…e.cs Co-authored-by: jkotas <[email protected]>
Copilot
AI
changed the title
[WIP] Refactor ArrayHelpers and TypedReferenceHelpers files
Refactor NativeAOT helpers to align with CoreCLR patterns
Oct 29, 2025
jkotas
reviewed
Oct 29, 2025
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Array.NativeAot.cs
Show resolved
Hide resolved
jkotas
reviewed
Oct 29, 2025
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Array.NativeAot.cs
Show resolved
Hide resolved
jkotas
reviewed
Oct 29, 2025
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Array.NativeAot.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 29, 2025
src/coreclr/nativeaot/System.Private.CoreLib/src/System/TypedReference.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 29, 2025
src/coreclr/nativeaot/System.Private.CoreLib/src/System/TypedReference.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 29, 2025
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/JitHelper.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 29, 2025
src/coreclr/nativeaot/System.Private.CoreLib/src/System/RuntimeTypeHandle.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 29, 2025
src/coreclr/nativeaot/System.Private.CoreLib/src/System/RuntimeTypeHandle.cs
Outdated
Show resolved
Hide resolved
…efAny, use GetCoreLibEntryPoint Co-authored-by: jkotas <[email protected]>
jkotas
reviewed
Oct 29, 2025
src/coreclr/System.Private.CoreLib/src/System/TypedReference.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 29, 2025
src/coreclr/nativeaot/System.Private.CoreLib/src/System/TypedReference.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 29, 2025
src/coreclr/nativeaot/System.Private.CoreLib/src/System/TypedReference.cs
Outdated
Show resolved
Hide resolved
Contributor
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
This was referenced Dec 3, 2025
jkotas
reviewed
Dec 31, 2025
jkotas
reviewed
Dec 31, 2025
Co-authored-by: jkotas <[email protected]>
Co-authored-by: jkotas <[email protected]>
jkotas
reviewed
Jan 1, 2026
src/coreclr/nativeaot/System.Private.CoreLib/src/System/RuntimeTypeHandle.cs
Show resolved
Hide resolved
jkotas
reviewed
Jan 1, 2026
|
|
||
| // Implementation of CORINFO_HELP_TYPEHANDLE_TO_RUNTIMETYPE, CORINFO_HELP_GETSYNCFROMCLASSHANDLE | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| internal static unsafe RuntimeType GetTypeFromMethodTable(MethodTable* pMT) |
…m Test.CoreLib Co-authored-by: jkotas <[email protected]>
Co-authored-by: jkotas <[email protected]>
jkotas
reviewed
Jan 1, 2026
jkotas
reviewed
Jan 1, 2026
src/coreclr/nativeaot/Test.CoreLib/src/System/RuntimeTypeHandle.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move helper methods from
ArrayHelpers.csandTypedReferenceHelpers.csto their appropriate target types and other changes to make NativeAOT and non-NativeAOT structure to be more similar.