Convert UInt128->float/Half with correct rounding#122170
Open
LEI-Hongfaan wants to merge 4 commits intodotnet:mainfrom
Open
Convert UInt128->float/Half with correct rounding#122170LEI-Hongfaan wants to merge 4 commits intodotnet:mainfrom
LEI-Hongfaan wants to merge 4 commits intodotnet:mainfrom
Conversation
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
jkotas
added
area-System.Numerics
and removed
needs-area-label
huoyaoyuan
reviewed
Dec 4, 2025
Member
huoyaoyuan
left a comment
huoyaoyuan
left a comment
There was a problem hiding this comment.
It's better to define some reusable generic math methods like BFloat16.RoundFromSigned, at least for same target FP type.
We also need tests added for the corner case it handles.
This was referenced Dec 4, 2025
Open
jeffhandley
requested changes
Feb 1, 2026
Member
jeffhandley
left a comment
jeffhandley
left a comment
There was a problem hiding this comment.
@LEI-Hongfaan Please add tests for the scenarios this addresses, and expand the PR description to describe which scenarios are now handled and which scenarios remain unresolved.
jeffhandley
added
the
needs-author-action
Contributor
|
This pull request has been automatically marked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #112474