issue #333; Feature- button in table to toggle datatype visibility #346
+66
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flashpunch0-0 is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@1ilit hey could you review the pr and if useful then merge it |
1ilit
requested changes
Mar 14, 2025
There was a problem hiding this comment.
I agree with @ian-barker, i think it would make more sense to have a showDataTypes setting in the SettingsContext which can be toggled form the view menu. You can look at how any other togglable settings field is implemented
|
yeah sure I'll take a look at some toggable settings and try to bring some possible changes |
|
@flashpunch0-0 let me know if there's anything i can help with |
…e_table_datatypes_flashpunch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current state of the project does not allow to toggle datatype visibility in table.
the new update will allow it to make the visualization look more clean.
changes done :
1- added a useState to toggle the value
2- Added a button with eyeiconopened and eyeiconclosed
3- added a popover above the icon to provide information about the button
4- changes the snippet code in field function
field function
updated code -
flow of usage - hover (get information) -> click (toggle viibility and eye icon changes)
Works for each table