-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature flag for importing passwords via Google Password Manager #5096
Add feature flag for importing passwords via Google Password Manager #5096
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
e474f86
to
845c86d
Compare
893a6a5
to
312493c
Compare
b76501a
to
0aa7a23
Compare
73e0f43
to
33924e6
Compare
override suspend fun getConfig(): AutofillImportPasswordSettings { | ||
return withContext(dispatchers.io()) { | ||
with(autofillFeature.canImportFromGooglePasswordManager()) { | ||
val config = getConfig() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you could rename the outer function for clarity, I thought it was recursive 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point; ditched that with
as it wasn't making the code any clearer and now there is no ambiguity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM 👍
f22ca04
to
91d0a37
Compare
b52488e
to
8c7ae28
Compare
8c7ae28
to
5256082
Compare
Task/Issue URL: https://app.asana.com/0/608920331025315/1207446004465151/f
Description
Sets up new remote config handling for autofill subfeature:
canImportFromGooglePasswordManager
This dictates whether we offer up the option to import passwords directly from Google Password Manager or not.
Additional config:
launchUrl
String
javascriptConfig
String
Steps to test this PR
Optional
Device Explorer
and check values look correct inshared_prefs/com.duckduckgo.feature.toggle.autofill.xml
Patch