Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch import flow from Password management screen #5098

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Oct 4, 2024

Task/Issue URL: https://app.asana.com/0/608920331025315/1208434183978073/f

Description

Adds UI which allows users to access the flow for importing passwords directly from Google Password Manager.

output

Steps to test this PR

Empty state

  • Fresh install
  • Visit Passwords screen and verify you see Import Passwords From Google button in the empty state (if WebView version supports it)

Pre-import dialog

  • Tap the button, and verify the bottom sheet looks good

Success results dialog

  • Tap Open Google Passwords button and complete the flow
  • Verify that you see the success dialog confirming how many passwords were imported.

Success results dialog (with duplicates detected)

  • [If you didn't see any duplicates in the last step] repeat previous step and verify duplicates are mentioned but not imported

Failure dialog
It's possible the flow couldn't be completed if the user enabled an old setting in GPM to encrypt passwords with a passphrase. Expecting this to be uncommon, but here's how to test the UI if this happens:

Copy link
Member Author

CDRussell commented Oct 4, 2024

@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 83c5c62 to f57e31f Compare October 4, 2024 15:26
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from cb0165a to a62bdee Compare October 4, 2024 15:26
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from f57e31f to 04c0006 Compare October 4, 2024 16:08
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from a62bdee to bdf9d39 Compare October 4, 2024 16:08
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 04c0006 to 460efc0 Compare October 7, 2024 13:11
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from bdf9d39 to e33bbd8 Compare October 7, 2024 13:11
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 460efc0 to 63c1596 Compare October 7, 2024 14:00
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch 2 times, most recently from 67dbcc4 to 51afeb4 Compare October 11, 2024 16:38
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 63c1596 to f4223cc Compare October 14, 2024 13:44
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from 51afeb4 to c18321f Compare October 14, 2024 13:44
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from f4223cc to 492da5a Compare October 14, 2024 15:49
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from c18321f to 3785b1d Compare October 14, 2024 15:49
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 492da5a to 36e9130 Compare October 21, 2024 11:31
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from 3785b1d to 97d434c Compare October 21, 2024 11:31
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 36e9130 to af68268 Compare October 21, 2024 11:35
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from 97d434c to 81af44c Compare October 21, 2024 11:35
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from af68268 to a9c3baf Compare October 21, 2024 11:40
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from 81af44c to f272996 Compare October 21, 2024 11:40
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from a9c3baf to 1c1a8b5 Compare October 21, 2024 12:06
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from f272996 to 2516f85 Compare October 21, 2024 12:06
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 1c1a8b5 to 60acf5f Compare October 21, 2024 12:57
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from 2516f85 to 2fbb14b Compare October 21, 2024 12:57
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 60acf5f to fd4d5b7 Compare October 21, 2024 13:02
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from 2fbb14b to dc1ceb8 Compare October 21, 2024 13:02
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from 35aa261 to caed3a6 Compare November 12, 2024 16:51
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 954ae7e to ed9ba10 Compare November 13, 2024 13:16
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from caed3a6 to b0de097 Compare November 13, 2024 13:16
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from ed9ba10 to cb3e6a0 Compare November 13, 2024 14:27
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from b0de097 to c6d18ad Compare November 13, 2024 14:27
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from cb3e6a0 to 93c018e Compare November 13, 2024 15:11
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch 3 times, most recently from 4f85b02 to 63479ec Compare November 13, 2024 15:39
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 93c018e to 1a9dd7e Compare November 13, 2024 16:56
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch 4 times, most recently from 2d1d2c0 to c74721e Compare November 14, 2024 16:35
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 1a9dd7e to 8359eef Compare November 14, 2024 16:46
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from c74721e to 9f0cf9b Compare November 14, 2024 16:46
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 8359eef to 14e9701 Compare November 14, 2024 17:22
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from 9f0cf9b to 7fbdaee Compare November 14, 2024 17:22
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 14e9701 to 8a49632 Compare November 14, 2024 17:31
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch 4 times, most recently from 4a983e8 to 133bd6b Compare November 14, 2024 17:52
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 8a49632 to 15eecd7 Compare November 14, 2024 18:17
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from 133bd6b to 732e58c Compare November 14, 2024 18:17
@CDRussell CDRussell marked this pull request as ready for review November 15, 2024 12:14
Base automatically changed from feature/craig/autofill_gpm_javascript to develop November 15, 2024 12:16
@CDRussell CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from 732e58c to 2a4356e Compare November 15, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants