-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch import flow from Password management screen #5098
Open
CDRussell
wants to merge
1
commit into
develop
Choose a base branch
from
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Launch import flow from Password management screen #5098
CDRussell
wants to merge
1
commit into
develop
from
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
22 tasks
CDRussell
force-pushed
the
feature/craig/autofill_gpm_javascript
branch
from
October 4, 2024 15:26
83c5c62
to
f57e31f
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
from
October 4, 2024 15:26
cb0165a
to
a62bdee
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_javascript
branch
from
October 4, 2024 16:08
f57e31f
to
04c0006
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
from
October 4, 2024 16:08
a62bdee
to
bdf9d39
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_javascript
branch
from
October 7, 2024 13:11
04c0006
to
460efc0
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
from
October 7, 2024 13:11
bdf9d39
to
e33bbd8
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_javascript
branch
from
October 7, 2024 14:00
460efc0
to
63c1596
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
2 times, most recently
from
October 11, 2024 16:38
67dbcc4
to
51afeb4
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_javascript
branch
from
October 14, 2024 13:44
63c1596
to
f4223cc
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
from
October 14, 2024 13:44
51afeb4
to
c18321f
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_javascript
branch
from
October 14, 2024 15:49
f4223cc
to
492da5a
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
from
October 14, 2024 15:49
c18321f
to
3785b1d
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_javascript
branch
from
October 21, 2024 11:31
492da5a
to
36e9130
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
from
October 21, 2024 11:31
3785b1d
to
97d434c
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_javascript
branch
from
October 21, 2024 11:35
36e9130
to
af68268
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
from
October 21, 2024 11:35
97d434c
to
81af44c
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_javascript
branch
from
October 21, 2024 11:40
af68268
to
a9c3baf
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
from
October 21, 2024 11:40
81af44c
to
f272996
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_javascript
branch
from
October 21, 2024 12:06
a9c3baf
to
1c1a8b5
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
from
October 21, 2024 12:06
f272996
to
2516f85
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_javascript
branch
from
October 21, 2024 12:57
1c1a8b5
to
60acf5f
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
from
October 21, 2024 12:57
2516f85
to
2fbb14b
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_javascript
branch
from
October 21, 2024 13:02
60acf5f
to
fd4d5b7
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
from
October 21, 2024 13:02
2fbb14b
to
dc1ceb8
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
from
November 12, 2024 16:51
35aa261
to
caed3a6
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_javascript
branch
from
November 13, 2024 13:16
954ae7e
to
ed9ba10
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
from
November 13, 2024 13:16
caed3a6
to
b0de097
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_javascript
branch
from
November 13, 2024 14:27
ed9ba10
to
cb3e6a0
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
from
November 13, 2024 14:27
b0de097
to
c6d18ad
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_javascript
branch
from
November 13, 2024 15:11
cb3e6a0
to
93c018e
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
3 times, most recently
from
November 13, 2024 15:39
4f85b02
to
63479ec
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_javascript
branch
from
November 13, 2024 16:56
93c018e
to
1a9dd7e
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
4 times, most recently
from
November 14, 2024 16:35
2d1d2c0
to
c74721e
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_javascript
branch
from
November 14, 2024 16:46
1a9dd7e
to
8359eef
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
from
November 14, 2024 16:46
c74721e
to
9f0cf9b
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_javascript
branch
from
November 14, 2024 17:22
8359eef
to
14e9701
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
from
November 14, 2024 17:22
9f0cf9b
to
7fbdaee
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_javascript
branch
from
November 14, 2024 17:31
14e9701
to
8a49632
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
4 times, most recently
from
November 14, 2024 17:52
4a983e8
to
133bd6b
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_javascript
branch
from
November 14, 2024 18:17
8a49632
to
15eecd7
Compare
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
from
November 14, 2024 18:17
133bd6b
to
732e58c
Compare
Base automatically changed from
feature/craig/autofill_gpm_javascript
to
develop
November 15, 2024 12:16
CDRussell
force-pushed
the
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
branch
from
November 15, 2024 12:17
732e58c
to
2a4356e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/608920331025315/1208434183978073/f
Description
Adds UI which allows users to access the flow for importing passwords directly from Google Password Manager.
Steps to test this PR
Empty state
Passwords
screen and verify you seeImport Passwords From Google
button in the empty state (ifWebView
version supports it)Pre-import dialog
Success results dialog
Open Google Passwords
button and complete the flowSuccess results dialog (with duplicates detected)
Failure dialog
It's possible the flow couldn't be completed if the user enabled an old setting in GPM to encrypt passwords with a passphrase. Expecting this to be uncommon, but here's how to test the UI if this happens: