Launch import flow from Password management screen by CDRussell · Pull Request #5098 · duckduckgo/Android

CDRussell · 2024-10-04T11:24:17Z

Task/Issue URL: https://app.asana.com/0/608920331025315/1208434183978073/f

Description

Adds UI which allows users to access the flow for importing passwords directly from Google Password Manager.

Steps to test this PR

Empty state

Fresh install
Visit Passwords screen and verify you see Import Passwords From Google button in the empty state (if WebView version supports it)

Pre-import dialog

Tap the button, and verify the bottom sheet looks good

Success results dialog

Tap Open Google Passwords button and complete the flow
Verify that you see the success dialog confirming how many passwords were imported.

Success results dialog (with duplicates detected)

[If you didn't see any duplicates in the last step] repeat previous step and verify duplicates are mentioned but not imported

Failure dialog
It's possible the flow couldn't be completed if the user enabled an old setting in GPM to encrypt passwords with a passphrase. Expecting this to be uncommon, but here's how to test the UI if this happens:

Apply Patch for testing: encrypted with passphrase
Start the import flow, and you'll see the error page
Tap the ✖️ button
Verify the results dialog shows an error state

CDRussell · 2024-10-04T11:24:26Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

CDRussell · 2024-11-18T15:15:29Z

...main/java/com/duckduckgo/autofill/impl/ui/credential/management/AutofillSettingsViewModel.kt

+        if (!importGooglePasswordButtonShownPixelSent) {
+            importGooglePasswordButtonShownPixelSent = true
+
+            // pixel to show import button would fire here


next PR will implement this

cmonfortep

LGTM, 👍

...main/java/com/duckduckgo/autofill/impl/ui/credential/management/AutofillSettingsViewModel.kt

...pl/src/main/java/com/duckduckgo/autofill/impl/deviceauth/AutofillAuthorizationGracePeriod.kt

.../com/duckduckgo/autofill/impl/ui/credential/management/viewing/AutofillManagementListMode.kt

CDRussell · 2024-11-21T14:42:10Z

Merge activity

Nov 21, 9:42 AM EST: A user started a stack merge that includes this pull request via Graphite.
Nov 21, 9:42 AM EST: A user merged this pull request with Graphite.

This was referenced Oct 4, 2024

Add ability to support importing passwords from Google as CSV #4601

Merged

Add developer settings for importing passwords from Google Password Manager #4602

Closed

Add feature flag for importing passwords via Google Password Manager #5096

Merged

CDRussell mentioned this pull request Oct 4, 2024

Add custom webview for importing via GPM #5097

Merged

22 tasks

CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 83c5c62 to f57e31f Compare October 4, 2024 15:26

CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from cb0165a to a62bdee Compare October 4, 2024 15:26

CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from f57e31f to 04c0006 Compare October 4, 2024 16:08

CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from a62bdee to bdf9d39 Compare October 4, 2024 16:08

CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 04c0006 to 460efc0 Compare October 7, 2024 13:11

CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from bdf9d39 to e33bbd8 Compare October 7, 2024 13:11

CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 460efc0 to 63c1596 Compare October 7, 2024 14:00

CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch 2 times, most recently from 67dbcc4 to 51afeb4 Compare October 11, 2024 16:38

CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 63c1596 to f4223cc Compare October 14, 2024 13:44

CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from 51afeb4 to c18321f Compare October 14, 2024 13:44

CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from f4223cc to 492da5a Compare October 14, 2024 15:49

CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from c18321f to 3785b1d Compare October 14, 2024 15:49

CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 492da5a to 36e9130 Compare October 21, 2024 11:31

CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from 3785b1d to 97d434c Compare October 21, 2024 11:31

CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 36e9130 to af68268 Compare October 21, 2024 11:35

CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from 97d434c to 81af44c Compare October 21, 2024 11:35

CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from af68268 to a9c3baf Compare October 21, 2024 11:40

CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from 81af44c to f272996 Compare October 21, 2024 11:40

CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from a9c3baf to 1c1a8b5 Compare October 21, 2024 12:06

CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from f272996 to 2516f85 Compare October 21, 2024 12:06

CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 1c1a8b5 to 60acf5f Compare October 21, 2024 12:57

CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from 2516f85 to 2fbb14b Compare October 21, 2024 12:57

CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 60acf5f to fd4d5b7 Compare October 21, 2024 13:02

CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from 2fbb14b to dc1ceb8 Compare October 21, 2024 13:02

CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 1a9dd7e to 8359eef Compare November 14, 2024 16:46

CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from c74721e to 9f0cf9b Compare November 14, 2024 16:46

CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 8359eef to 14e9701 Compare November 14, 2024 17:22

CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from 9f0cf9b to 7fbdaee Compare November 14, 2024 17:22

CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 14e9701 to 8a49632 Compare November 14, 2024 17:31

CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch 4 times, most recently from 4a983e8 to 133bd6b Compare November 14, 2024 17:52

CDRussell force-pushed the feature/craig/autofill_gpm_javascript branch from 8a49632 to 15eecd7 Compare November 14, 2024 18:17

CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from 133bd6b to 732e58c Compare November 14, 2024 18:17

CDRussell assigned cmonfortep Nov 15, 2024

CDRussell marked this pull request as ready for review November 15, 2024 12:14

Base automatically changed from feature/craig/autofill_gpm_javascript to develop November 15, 2024 12:16

CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from 732e58c to 2a4356e Compare November 15, 2024 12:17

CDRussell mentioned this pull request Nov 18, 2024

Add pixels for importing google passwords metrics #5284

Merged

29 tasks

CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch 2 times, most recently from d9b11c1 to 720a9dc Compare November 18, 2024 14:26

CDRussell commented Nov 18, 2024

View reviewed changes

cmonfortep approved these changes Nov 18, 2024

View reviewed changes

CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch 2 times, most recently from c1cc10b to 3ae18f9 Compare November 20, 2024 23:02

CDRussell changed the base branch from develop to feature/craig/autofill_gpm_css_fix_include_js November 20, 2024 23:02

CDRussell mentioned this pull request Nov 20, 2024

Fix missing c-s-s password import JS file and gitignore #5295

Merged

1 task

Base automatically changed from feature/craig/autofill_gpm_css_fix_include_js to develop November 21, 2024 09:57

Launch import flow from Password management screen

d702bc0

CDRussell force-pushed the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch from 3ae18f9 to d702bc0 Compare November 21, 2024 09:57

CDRussell merged commit 1a6c073 into develop Nov 21, 2024

CDRussell deleted the feature/craig/autofill_gpm_ui_to_launch_from_password_manager branch November 21, 2024 14:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Launch import flow from Password management screen#5098

Launch import flow from Password management screen#5098
CDRussell merged 1 commit intodevelopfrom
feature/craig/autofill_gpm_ui_to_launch_from_password_manager

CDRussell commented Oct 4, 2024 •

edited

Loading

Uh oh!

CDRussell commented Oct 4, 2024 •

edited

Loading

Uh oh!

CDRussell Nov 18, 2024

Uh oh!

cmonfortep left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CDRussell commented Nov 21, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

CDRussell commented Oct 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Steps to test this PR

Uh oh!

CDRussell commented Oct 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CDRussell Nov 18, 2024

Choose a reason for hiding this comment

Uh oh!

cmonfortep left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CDRussell commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CDRussell commented Oct 4, 2024 •

edited

Loading

CDRussell commented Oct 4, 2024 •

edited

Loading

CDRussell commented Nov 21, 2024 •

edited

Loading