Add pixels for importing google passwords metrics

[CDRussell]

Task/Issue URL: https://app.asana.com/0/608920331025315/1208787586139232/f

Description

Adds metrics around the import password flow. To support this in a flexible way, it also allows for the url mappings to be defined remotely for which stage of the flow a user dropped out at if they didn't go all the way through; if we ever need to, can override the default url mappings.

Logcat filter: message~:"Pixel sent: autofill_import_google_passwords"

Steps to test this PR

Setup

• Fresh install

Cancelling the user journey

• Visit Passwords screen, and verify autofill_import_google_passwords_import_button_shown in logs for the import password button being shown
• Tap on Import Passwords From Google button; verifyautofill_import_google_passwords_import_button_tapped in logs
• Verify autofill_import_google_passwords_preimport_prompt_displayed in logs
• Dismiss the import dialog; verifyautofill_import_google_passwords_result_user_cancelled in logs
• Tap on Import Passwords From Google button again.
• This time, tap on the Open Google Passwords button; verifyautofill_import_google_passwords_preimport_prompt_confirmed in logs
• Tap the ✖️ button to quit the import flow; verifyautofill_import_google_passwords_result_user_cancelled in logs, with stage=webflow-pre-login
• Dismiss the dialog that is still showing, and verify there is not a further cancellation pixel in logs for when the dialog closes, as this is already covered by the ✖️ button cancellation
• Launch the import flow again. This time tap on the Sign in button. Then ✖️ to exit the flow; verify autofill_import_google_passwords_result_user_cancelled with stage=webflow-authenticate
• Launch the import flow again. This time, actually sign in, then ✖️ to exit the flow; verify autofill_import_google_passwords_result_user_cancelled with stage=webflow-post-login-landing
• Launch the import flow again, and you'll be on the screen with the export button. tap ✖️ to exit the flow; verify autofill_import_google_passwords_result_user_cancelled with stage=webflow-export
• Launch the import flow again. Tap the export button, and agree on the dialog. Then when prompted to authenticate, tap ✖️ to exit the flow; verify autofill_import_google_passwords_result_user_cancelled with stage=webflow-authenticate

Succeeding

• Launch the import flow and fully complete it. Verify autofill_import_google_passwords_result_success, with the correct bucket for saved_credentials and skipped_credentials based on bucket rules defined here
• Repeat that, and you should get duplicates this time. Verify again, ensuring that skipped_credentials bucket is accurate.

Overflow menu

• Now that you have saved passwords, Import Passwords From Google will appear in the overflow menu. Tap on that. Verify autofill_import_google_passwords_overflow_menu_tapped and autofill_import_google_passwords_preimport_prompt_displayed in logs

Encrypted passphrase scenario

• Apply patch
• Launch import flow and you'll see the error screen. Tap ✖️ to exit flow. Verify autofill_import_google_passwords_result_user_cancelled with stage=webflow-passphrase-encryption

CSV parsing scenario

• Discard local changes
• Apply patch
• Launch import flow and carry on until you've exported. The patch will simulate an error. Verify autofill_import_google_passwords_result_parsing in logs.

URL mapping via remote config

• Discard local changes
• Apply patch to override the URL mappings
• Fresh install. Launch password import flow and then ✖️ to exit. Verify in logs with filter urlMappings that the mappings from the patched jsonblob are used and override the local defaults.

Selectively disabling JS injection

• Discard local changes
• Apply patch which simulates disabling remote config for JS injection specifically.
• Fresh install
• Launch password import flow; verify you don't see any UI hints on which button to press
• Complete the flow; verify it still works as expected

[CDRussell]

• Add pixels for importing google passwords metrics #5284 👈 (View in Graphite)
• Launch import flow from Password management screen #5098
• Fix missing c-s-s password import JS file and gitignore #5295
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

[CDRussell]

as discussed, adding in ability to selectively disable just the JS injection

[CDRussell]

for determining where in the webflow cancellation took place, we need to map URLs to a known string. there will be default mappings in place, but we can also override with remote config.

[CDRussell]

handling ENCRYPTED_PASSPHRASE_ERROR_URL as another of the cancellation cases so don't need special treatment here for it

[cmonfortep]

LGTM, everything works as expected.

Just a note, when reading in the latest scenario "Launch password import flow; verify you don't see any UI hints on which button to press", I was surprised because I didn't have hint in the previous scenarios. Let's review that tomorrow.

[cmonfortep]

Do we need to add them to remove atb or similar?

[CDRussell]

No, keeping ATB et al.

[CDRussell]

LGTM, everything works as expected.

Just a note, when reading in the latest scenario "Launch password import flow; verify you don't see any UI hints on which button to press", I was surprised because I didn't have hint in the previous scenarios. Let's review that tomorrow.

Isolated the problem and fixed in #5295. this branch has been restacked on top, meaning if you test again you should see the hints working now. good spot!

[CDRussell]

Merge activity

• Nov 21, 9:42 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Nov 21, 9:44 AM EST: Graphite rebased this pull request as part of a merge.
• Nov 21, 9:59 AM EST: A user merged this pull request with Graphite.