Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pixels and remove ATB #5237

Merged

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Nov 5, 2024

Task/Issue URL: https://app.asana.com/0/1204920898013511/1208577246155731/f

Description

Steps to test this PR

Feature 1

  • Check site_not_working_shown is fired when the prompt is shown
  • Check site_not_working_website_is_broken when report broken site is pressed

Copy link
Contributor Author

CrisBarreiro commented Nov 5, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CrisBarreiro and the rest of your teammates on Graphite Graphite

This was referenced Nov 5, 2024
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/add-pixels branch from 76e472b to c3d12ab Compare November 5, 2024 11:58
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/limiting-logic branch from eedaac2 to b2c7282 Compare November 6, 2024 12:22
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/add-pixels branch from c3d12ab to 105fc0a Compare November 6, 2024 12:31
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/limiting-logic branch from b2c7282 to b0b1d34 Compare November 7, 2024 08:42
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/add-pixels branch from 105fc0a to df4c66f Compare November 7, 2024 08:42
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/limiting-logic branch from b0b1d34 to 11a19bf Compare November 7, 2024 09:58
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/add-pixels branch from df4c66f to cca210f Compare November 7, 2024 09:58
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/limiting-logic branch from 11a19bf to c0e3eee Compare November 7, 2024 14:47
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/add-pixels branch from cca210f to 3370b9e Compare November 7, 2024 14:47
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/limiting-logic branch from c0e3eee to 2007cb7 Compare November 7, 2024 15:49
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/add-pixels branch 2 times, most recently from 81bdab9 to b474a78 Compare November 7, 2024 16:46
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/limiting-logic branch from 5ba63b9 to 4c82df7 Compare November 7, 2024 17:20
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/add-pixels branch from b474a78 to f5f01d4 Compare November 7, 2024 17:20
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/limiting-logic branch from 4c82df7 to d247aa0 Compare November 7, 2024 17:29
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/add-pixels branch from 7ddaf49 to 68a919e Compare November 7, 2024 17:29
Base automatically changed from feature/cris/broken-site/limiting-logic to feature/cris/broken-site/base November 7, 2024 20:12
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/base branch 2 times, most recently from 0598f61 to 91ca637 Compare November 8, 2024 11:34
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/add-pixels branch from 68a919e to bfef16d Compare November 8, 2024 11:34
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/add-pixels branch 2 times, most recently from fcfe1ce to 81b65e5 Compare November 12, 2024 08:10
Copy link
Contributor

@lmac012 lmac012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/add-pixels branch from 81b65e5 to c6da822 Compare November 13, 2024 17:45
@CrisBarreiro CrisBarreiro merged commit c6da822 into feature/cris/broken-site/base Nov 13, 2024
4 of 5 checks passed
@CrisBarreiro CrisBarreiro deleted the feature/cris/broken-site/add-pixels branch November 13, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants