Update copy and request translations #5260
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CrisBarreiro
force-pushed
the
feature/cris/broken-site/add-pixels
branch
from
bfef16d
to
fcfe1ce
Compare
CrisBarreiro
force-pushed
the
feature/cris/broken-site/l10n
branch
from
d995a2e
to
6054c13
Compare
CrisBarreiro
force-pushed
the
feature/cris/broken-site/add-pixels
branch
from
fcfe1ce
to
81b65e5
Compare
CrisBarreiro
force-pushed
the
feature/cris/broken-site/l10n
branch
from
6054c13
to
31550e9
Compare
There was a problem hiding this comment.
@CrisBarreiro this file is wrong.
It's missing the smartling instructions at the top:
<!-- smartling.entity_escaping = false -->
<!-- smartling.instruction_attributes = instruction -->
And the file name is the other way around, should be strings-broken-site.xml, this is why the automation is not picking it up. Note when you change the file name, it will run through the automation.
CrisBarreiro
force-pushed
the
feature/cris/broken-site/add-pixels
branch
from
81b65e5
to
c6da822
Compare
CrisBarreiro
force-pushed
the
feature/cris/broken-site/l10n
branch
from
41a07ea
to
71623f6
Compare
@marcosholgado that's fixed now and the automation is working properly. Could you please review? |
Translate strings-broken-site to values-sl Translate strings-broken-site to values-fi Translate strings-broken-site to values-es Translate strings-broken-site to values-pt Translate strings-broken-site to values-fr Translate strings-broken-site to values-da Translate strings-broken-site to values-hr Translate strings-broken-site to values-de Translate strings-broken-site to values-it Translate strings-broken-site to values-sv Translate strings-broken-site to values-tr Translate strings-broken-site to values-hu Translate strings-broken-site to values-ru Translate strings-broken-site to values-el Translate strings-broken-site to values-sk Translate strings-broken-site to values-nl Translate strings-broken-site to values-lv Translate strings-broken-site to values-pl
CrisBarreiro
force-pushed
the
feature/cris/broken-site/base
branch
from
c6da822
to
bb2a60c
Compare
CrisBarreiro
force-pushed
the
feature/cris/broken-site/l10n
branch
from
71623f6
to
3a0afb6
Compare
Task/Issue URL: https://app.asana.com/0/1204920898013511/1208577246155728/f
https://dashboard.smartling.com/app/projects/b01b53ede/account-jobs/b01b53ede:hlnez7ekeaqw?filter=ALL&projectIds[]=b01b53ede
Description
Steps to test this PR
Feature 1
UI changes