-
Notifications
You must be signed in to change notification settings - Fork 161
Add component_sub_point to composer #843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5135f41 to
9e912a3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #843 +/- ##
==========================================
+ Coverage 85.44% 85.55% +0.10%
==========================================
Files 57 57
Lines 3725 3781 +56
==========================================
+ Hits 3183 3235 +52
- Misses 542 546 +4
Continue to review full report in Codecov by Sentry.
|
moCello
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General LGTM, although while we're at it, I would also add a component_neg_point.
57a0585 to
3049907
Compare
3566e8c to
1ab0748
Compare
1ab0748 to
e79633d
Compare
marta-belles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves: #842