Skip to content

Conversation

@xevisalle
Copy link
Member

@xevisalle xevisalle commented Jan 31, 2025

Resolves: #842

@xevisalle xevisalle linked an issue Jan 31, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.55%. Comparing base (0e75be5) to head (e79633d).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
tests/ecc.rs 92.15% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #843      +/-   ##
==========================================
+ Coverage   85.44%   85.55%   +0.10%     
==========================================
  Files          57       57              
  Lines        3725     3781      +56     
==========================================
+ Hits         3183     3235      +52     
- Misses        542      546       +4     
Files with missing lines Coverage Δ
src/composer.rs 90.55% <100.00%> (+0.18%) ⬆️
tests/ecc.rs 89.23% <92.15%> (+1.88%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e75be5...e79633d. Read the comment docs.

Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General LGTM, although while we're at it, I would also add a component_neg_point.

Copy link
Contributor

@marta-belles marta-belles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xevisalle xevisalle merged commit a39aa65 into master Feb 4, 2025
11 checks passed
@xevisalle xevisalle deleted the sub_circuit branch February 4, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add component to subtract points in-circuit

4 participants