Close connections asynchronously (2) #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm good with this @rPraml . I plan to maybe do a followup PR which replaces the Timer with something that gives the option of using a Java 21 Virtual Thread instead |
And regardless of how well close executes/fails/slow etc
- Start on pool creation - Stop on fullShutdown of pool - ExecutorService becomes final
To protect against a possible race condition between a shutdown hook invocation and application code invocation.
|
Ok, I reckon this is good. I'll merge @rPraml and we can adjust afterwards if you see something. |
|
@rbygrave Thanks for reviewing and merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.