Conversation
|
Hello, Could anyone check the issue (and fix) coz the bug breaks custom deserializations. Tnx |
|
Thanks for your contribution. Would you be able to write a functional test replicating the failure you were getting before and showing that your fix works. |
|
I added a simple test that should crash without a patch. Note that the problem is in a way jakarta specifications done (e.g. json-b or jsonp). In this particular case I test Should it be two separate tests? Cheers, Dmitry P.S. Probably it would be more correct to catch the exception and explicitly fail in the test... |
KyleAure
left a comment
There was a problem hiding this comment.
Note that the problem is in a way jakarta specifications done (e.g. json-b or jsonp).
Providing default methods in interfaces that rise "not implemented" exception is awkward - implementers just "forget" to implement methods as no compile errors is thrown.
I agree, I think more recently the Jakarta Specification group has been more strict about "optional" features in the API and SPECs. Thanks again for filling in these gaps, just a few missing parts that I made suggestions for below.
| default: | ||
| //no other changes needed | ||
| } | ||
| return next; |
There was a problem hiding this comment.
todo: update copyright header with a new line below the previous Oracle line:
Copyright (c) 2026 Contributors to the Eclipse Foundation
Fix for the #673