Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shut down ROM class cache if purging all clients #18656

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

cjjdespres
Copy link
Contributor

@cjjdespres cjjdespres commented Dec 19, 2023

The JITServer expects that the shared ROM class cache will have been initialized only if the _clientSessionMap is empty.

Fixes #18631.

@cjjdespres cjjdespres requested a review from dsouzai as a code owner December 19, 2023 20:12
The JITServer expects that the shared ROM class cache will have been
initialized only if the _clientSessionMap is empty.

Fixes: eclipse-openj9#18631

Signed-off-by: Christian Despres <[email protected]>
@cjjdespres
Copy link
Contributor Author

Attn @mpirvu.

Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpirvu mpirvu self-assigned this Dec 21, 2023
@mpirvu mpirvu added the comp:jitserver Artifacts related to JIT-as-a-Service project label Dec 21, 2023
@mpirvu
Copy link
Contributor

mpirvu commented Dec 21, 2023

jenkins test sanity plinuxjit,xlinuxjit,zlinuxjit,alinux64jit jdk17

@cjjdespres
Copy link
Contributor Author

The failures on aarch64 look like #18436.

@mpirvu
Copy link
Contributor

mpirvu commented Jan 2, 2024

jenkins test sanity xlinuxjit jdk17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

JITServerSharedROMClassCache double-initialization after purging all client session data triggers assert
2 participants