-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider EE requirements in EE-Section of ManifestEditor #1318
base: master
Are you sure you want to change the base?
Conversation
56dfac0
to
c815c5b
Compare
c815c5b
to
a54f79f
Compare
Previously the |
c1392be
to
b7ee184
Compare
7ddc4e9
to
ccc7dcd
Compare
ccc7dcd
to
7151716
Compare
I just wanted to note one do not need a resolved state for this. Assume you have the String and parse it into a
to get an OSGi Resource from it, something similar can be archived with P2 in One can possibly hide this of course in a Util method as well, e.g. |
The
Execution Environments
section in the Manifest Editor is currently empty if a bundle only specifies an EE requirement instead of a dedicatedBundle-RequiredExecutionEnvironment
header.For example for third-party OSGi bundles published to Maven-Central this is quite common.
With this change EE requirements are now considered as well:
The main building block for that is the addition of new method
ManifestUtils.getRequiredExecutionEnvironments()
in the first commit, that derives the required EEs of an OSGi resource based on its EE requirements. For that it only uses the OSGi resources API and is thus one small step to migrate PDE off the Equinox resolver API.