Initial proposal for feature request #803

antonkri · 2025-03-27T15:59:18Z

No description provided.

github-actions · 2025-03-27T16:00:12Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
INFO: Invocation ID: 858330f0-efe3-4e9a-8006-a09d3ef4d21e
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'aspect_rules_lint', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/score/score/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/score/score/BUILD
INFO: Elapsed time: 6.676s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

docs/contribute/contribution_request/feature_request.rst

github-actions · 2025-03-27T16:02:19Z

The created documentation from the pull request is available at: docu-html

docs/contribute/contribution_request/feature_request.rst

masc2023 · 2025-03-27T16:05:57Z

docs/contribute/contribution_request/feature_request.rst

+  * **Accepted** - You feature request is accepted. The technical leads will create a GitHub issue of type 'Epic', where detailed information regarding your feature will be documented.
+    Afterwards the epic will be assigned to the corresponding team (CFT/Community). If none of the CFTs/Communities match the new *feature request*, then a new CFT/Community will be founden. You will be invited to 
+    the CFT/Community for break down of the *feature request* and planning.
+  * **Rejected** - You *feature request* was rejected. It could be either because you description was not mature enough or because the proposal technically doesn't fit into S-CORE roadmap or architecture.


is rejected, as above is accepted

don't get it

just grammar, you use is accepted, but was rejected, I just propose is rejected

docs/contribute/contribution_request/feature_request.rst

masc2023

Please align with Change Management

4og · 2025-03-31T10:03:01Z

html.tar.gz

Is this tarball added by mistake?

qor-lb

Overall the guidance is very good and helps to understand the process behind FR's 👍 There are some minor grammar issues, maybe you could run it through Copilot/ChatGPT/... once to clean up the wording and fix the grammar.

docs/contribute/contribution_request/feature_request.rst

Initial proposal for feature request

markert-r · 2025-05-13T15:09:04Z

docs/contribute/contribution_request/feature_request.rst

+
+Creation of Feature Request
+================================
+* As the very first step, you will need to become of an official contributor, as described in


... you will need to become an official ... -> remove of

markert-r · 2025-05-13T15:11:26Z

docs/contribute/contribution_request/feature_request.rst

+
+* After you have created a GitHub Issue, next step would be to start working on the *feature request*.
+  First of all, change the status of *Feature Request* to "in Progress" state.
+  *Feature Requests*, that stay in the status "Draft" for a longer period of time, will be deleted.


We should specify how long this period is.

Perhaps it would be better to set the status to "Obsolete" instead of deleting them?

changed to 4 weeks

docs/contribute/contribution_request/feature_request.rst

markert-r · 2025-05-13T15:22:45Z

docs/contribute/contribution_request/feature_request.rst

+* As the very first step, you will need to become of an official contributor, as described in
+  `Actions to Ensure Proper Contribution  <https://eclipse-score.github.io/score/main/contribute/general/contribution_attribution.html#contribution-attribution>`_
+
+* Afterwards you will be able to create a GitHub Issue and mark it


For me it is not clear whether a feature request is just a GitHub issue with the label feature_request or whether something else belongs to the feature request.

See above, compare Change Management, Feature Request Template is an rst file must be part of PR linked to the FR Issue

It is actually explained later, at the end of the paragraph. I've also added a link to change request workflow there.

markert-r · 2025-05-13T15:23:52Z

docs/contribute/contribution_request/feature_request.rst

+* As the very first step, you will need to become of an official contributor, as described in
+  `Actions to Ensure Proper Contribution  <https://eclipse-score.github.io/score/main/contribute/general/contribution_attribution.html#contribution-attribution>`_
+
+* Afterwards you will be able to create a GitHub Issue and mark it


In which repository or project shall the GitHub issues be created?

added reference to s-core repository

markert-r · 2025-05-13T15:25:08Z

docs/contribute/contribution_request/feature_request.rst

+  As soon as you've labeled your GitHub Issue with *feature request*/*feature_modification* label,
+  TLs will see the *feature request* and will add it to the special GitHub project,
+  `Feature Request GitHub Project <https://github.com/orgs/eclipse-score/projects/4>`_.
+  Inside of this *Feature Request GitHub Project* additional states are used for a better tracking of the *feature requests*.


Add link to description of the different states?

Added a table with additional description

docs/contribute/contribution_request/feature_request.rst

markert-r · 2025-05-13T15:29:31Z

docs/contribute/contribution_request/feature_request.rst

+  that they can start with the process of reviewing the *feature request*. Technical Leads will first do a short review of your *feature request*:
+
+  * In case the impact of your *feature request* is trivial, then TLs can process your *feature request* immediately.
+  * Normally, TL circle will put the lead of the appropriate *CFT* or *Community* as reviewer to the corresponding PR of the *feature request* for better analysis.


CFT = feature team

was changed

docs/contribute/contribution_request/feature_request.rst

Signed-off-by: Frank Scholter Peres(MBTI) <[email protected]>

4og · 2025-05-14T14:17:52Z

I'm not sure if this should be included in this PR or in a follow-up, but it's worth mentioning that there is also a Component Request concept as described in https://eclipse-score.github.io/score/main/process/process_areas/change_management/guidance/change_management_guideline.html

For example, in the context of Baselibs, which is a Feature, adding a Rust implementation of a JSON library would require a Component Request.

markert-r · 2025-05-16T11:22:57Z

docs/contribute/contribution_request/feature_request.rst

+    The review comments will be done directly in the *feature request* PR.
+  * **POC needed** - We generally like your idea, but we don't have enough technical understanding of the *feature request*,
+    e.g. technical scope is too big, and we need a POC to be able to understand better,
+    how the proposed *feature request* fits into the overall solution. You will find in the GitHub issue comments the information what your POC should focus on.


Will it also be specified in the GitHub issue what the scope of the PoC should be and what are the requirements and the acceptance criteria for the requested PoC?

took over your phrasing to the document

markert-r

Please address the findings / comments.

docs/contribute/contribution_request/feature_request.rst

Fix multiple findings in the PR

masc2023

Is now fine

masc2023 · 2025-05-14T04:42:04Z

docs/contribute/contribution_request/feature_request.rst

+* As the very first step, you will need to become of an official contributor, as described in
+  `Actions to Ensure Proper Contribution  <https://eclipse-score.github.io/score/main/contribute/general/contribution_attribution.html#contribution-attribution>`_
+
+* Afterwards you will be able to create a GitHub Issue and mark it


docs/contribute/contribution_request/feature_request.rst

masc2023 · 2025-05-14T04:46:03Z

docs/contribute/contribution_request/feature_request.rst

+  * **Accepted** - You feature request is accepted. The technical leads will create a GitHub issue of type 'Epic', where detailed information regarding your feature will be documented.
+    Afterwards the epic will be assigned to the corresponding team (CFT/Community). If none of the CFTs/Communities match the new *feature request*, then a new CFT/Community will be founden. You will be invited to 
+    the CFT/Community for break down of the *feature request* and planning.
+  * **Rejected** - You *feature request* was rejected. It could be either because you description was not mature enough or because the proposal technically doesn't fit into S-CORE roadmap or architecture.


just grammar, you use is accepted, but was rejected, I just propose is rejected

masc2023 reviewed Mar 27, 2025

View reviewed changes

docs/contribute/contribution_request/feature_request.rst Outdated Show resolved Hide resolved

masc2023 reviewed Mar 27, 2025

View reviewed changes

docs/contribute/contribution_request/feature_request.rst Outdated Show resolved Hide resolved

masc2023 reviewed Mar 27, 2025

View reviewed changes

docs/contribute/contribution_request/feature_request.rst Outdated Show resolved Hide resolved

masc2023 reviewed Mar 27, 2025

View reviewed changes

docs/contribute/contribution_request/feature_request.rst Outdated Show resolved Hide resolved

masc2023 reviewed Mar 27, 2025

View reviewed changes

docs/contribute/contribution_request/feature_request.rst Outdated Show resolved Hide resolved

masc2023 requested changes Mar 27, 2025

View reviewed changes

4og reviewed Mar 31, 2025

View reviewed changes

antonkri mentioned this pull request May 5, 2025

Improvement: TL should agree on the process for approving Feature Requests #1031

Closed

antonkri force-pushed the ankr_feature_request branch 6 times, most recently from c4536b5 to 4c6308d Compare May 12, 2025 12:20

antonkri changed the title ~~WIP: Initial proposal for feature request~~ Initial proposal for feature request May 12, 2025

antonkri force-pushed the ankr_feature_request branch from 4c6308d to 72d15f0 Compare May 13, 2025 06:42

qor-lb reviewed May 13, 2025

View reviewed changes

docs/contribute/contribution_request/feature_request.rst Outdated Show resolved Hide resolved

docs/contribute/contribution_request/feature_request.rst Outdated Show resolved Hide resolved

docs: feature_request proposal

d85a994

Initial proposal for feature request

antonkri force-pushed the ankr_feature_request branch from 72d15f0 to d85a994 Compare May 13, 2025 11:06

qor-lb previously approved these changes May 13, 2025

View reviewed changes

markert-r reviewed May 13, 2025

View reviewed changes

docs/contribute/contribution_request/feature_request.rst Show resolved Hide resolved

markert-r reviewed May 13, 2025

View reviewed changes

docs/contribute/contribution_request/feature_request.rst Show resolved Hide resolved

markert-r reviewed May 13, 2025

View reviewed changes

docs/contribute/contribution_request/feature_request.rst Show resolved Hide resolved

markert-r reviewed May 13, 2025

View reviewed changes

docs/contribute/contribution_request/feature_request.rst Show resolved Hide resolved

markert-r reviewed May 13, 2025

View reviewed changes

docs/contribute/contribution_request/feature_request.rst Show resolved Hide resolved

markert-r reviewed May 13, 2025

View reviewed changes

docs/contribute/contribution_request/feature_request.rst Show resolved Hide resolved

Replaced cft with ft

e5afd96

Signed-off-by: Frank Scholter Peres(MBTI) <[email protected]>

FScholPer dismissed qor-lb’s stale review via e5afd96 May 14, 2025 08:33

docs: One additional CFT replaced with FT

7ab587b

Signed-off-by: Frank Scholter Peres(MBTI) <[email protected]>

markert-r reviewed May 16, 2025

View reviewed changes

markert-r requested changes May 16, 2025

View reviewed changes

docs/contribute/contribution_request/feature_request.rst Show resolved Hide resolved

docs: fix findings in PR

4a0b6c3

Fix multiple findings in the PR

qor-lb force-pushed the ankr_feature_request branch 2 times, most recently from bdb1716 to 458cd23 Compare May 19, 2025 13:13

masc2023 previously approved these changes May 22, 2025

View reviewed changes

docs: added acceptance criteria to feature request guideline

408517a

antonkri dismissed masc2023’s stale review via 408517a May 22, 2025 12:24

antonkri force-pushed the ankr_feature_request branch from 458cd23 to 408517a Compare May 22, 2025 12:24

markert-r approved these changes May 22, 2025

View reviewed changes

antonkri merged commit 349693a into main May 22, 2025
8 checks passed

antonkri deleted the ankr_feature_request branch May 22, 2025 12:56

Initial proposal for feature request #803

Initial proposal for feature request #803

Uh oh!

Conversation

antonkri commented Mar 27, 2025

Uh oh!

github-actions bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 27, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

masc2023 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qor-lb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markert-r May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

4og commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

antonkri May 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 27, 2025 •

edited

Loading

markert-r May 13, 2025 •

edited

Loading

4og commented May 14, 2025 •

edited

Loading

antonkri May 18, 2025 •

edited

Loading