Handle the case of empty BSN in maven target location #4700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
added
the
backport-to-tycho-4.0.x
It seem for some reasons there are "bundles" in the wild that contain an OSGi manifest with an empty BSN what currently leads to a NPE if used inside a target. This now enhances the check for a valid OSGi manifest in a way that it is not only required to have a BSN but also that it is not empty.
laeubi
force-pushed
the
fix_bad_manifest_in_target
branch
from
197ef25 to
83cb758
Compare
Test Results 609 files ±0 609 suites ±0 4h 3m 8s ⏱️ + 1m 58s For more details on these failures, see this check. Results for commit 83cb758. ± Comparison against base commit 69f9754. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seem for some reasons there are "bundles" in the wild that contain an OSGi manifest with an empty BSN what currently leads to a NPE if used inside a target.
This now enhances the check for a valid OSGi manifest in a way that it is not only required to have a BSN but also that it is not empty.