Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tycho-4.0.x] Handle the case of empty BSN in maven target location #4701

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

eclipse-tycho-bot
Copy link

Backport

This will backport the following commits from main to tycho-4.0.x:

Questions ?

Please refer to the Backport tool documentation

Copy link

github-actions bot commented Feb 8, 2025

Test Results

  606 files  ±0    606 suites  ±0   3h 50m 50s ⏱️ - 20m 40s
  424 tests ±0    418 ✅ ±0   6 💤 ±0  0 ❌ ±0 
1 272 runs  ±0  1 253 ✅ ±0  19 💤 ±0  0 ❌ ±0 

Results for commit 47abe19. ± Comparison against base commit 5d4e258.

♻️ This comment has been updated with latest results.

It seem for some reasons there are "bundles" in the wild that contain an
OSGi manifest with an empty BSN what currently leads to a NPE if used
inside a target.

This now enhances the check for a valid OSGi manifest in a way that it
is not only required to have a BSN but also that it is not empty.

(cherry picked from commit a55b0e3)
@laeubi laeubi force-pushed the backport/tycho-4.0.x/pr-4700 branch from ac9659b to 47abe19 Compare February 8, 2025 16:50
@eclipse-tycho-bot eclipse-tycho-bot merged commit c4e3e0c into tycho-4.0.x Feb 8, 2025
15 checks passed
@akurtakov akurtakov deleted the backport/tycho-4.0.x/pr-4700 branch February 12, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants