-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace docker-compose by 'docker compose' #40890
base: main
Are you sure you want to change the base?
Conversation
The docker Compose V1 (docker-compose) stopped receiving updates on July 2023, this PR updates our automation tools to use the new Compose V2 (docker compose). Compose V2 has been GA since April 2022. More information on https://www.docker.com/blog/new-docker-compose-v2-and-v1-deprecation/.
718688b
to
37a915c
Compare
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
This pull request doesn't have a |
I'm not sure if compose is installed by default in a docker installation, we might have to update images to install the plugin. Reading https://www.docker.com/blog/announcing-compose-v2-general-availability/ it seems that it only comes with Docker Desktop by default. |
// PATH. | ||
func HaveDockerCompose() error { | ||
_, err := exec.LookPath("docker-compose") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also make sure that compose plugin is installed by runnigg (docker compose version
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also make sure that compose plugin is installed by runnigg (
docker compose version
)
What do you mean? Call docker compose version
, parse the output and ensure the compose plugin is installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this makes sense if the plugin is installed separately than docker itself. Otherwise, you are just testing that docker is available here, and not compose.
Proposed commit message
The docker Compose V1 (docker-compose) stopped receiving updates on July 2023, this PR updates our automation tools to use the new Compose V2 (docker compose). Compose V2 has been GA since April 2022.
More information on
https://www.docker.com/blog/new-docker-compose-v2-and-v1-deprecation/.
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
There is no disruptive user impact
## Author's ChecklistHow to test this PR locally
Run any mage /make target that uses docker, like the python integration tests
## Related issues## Use cases## Screenshots## Logs