Accomodate logger changes from `tlscommon` package #46308

khushijain21 · 2025-08-29T07:26:37Z

Proposed commit message

This PR accommodates breaking changes made in elastic-agent-libs . It effectively uses local logger in place of global ones

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

github-actions · 2025-08-29T07:26:47Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

mergify · 2025-08-29T07:27:18Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @khushijain21? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
backport-active-all is the label that automatically backports to all active branches.
backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

elasticmachine · 2025-08-29T07:28:18Z

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

elasticmachine · 2025-08-29T07:28:27Z

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

elasticmachine · 2025-08-29T07:28:34Z

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

elasticmachine · 2025-08-29T07:28:39Z

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

x-pack/filebeat/input/cel/input_manager.go

x-pack/filebeat/input/cel/input_test.go

x-pack/libbeat/reader/parquet/parquet_test.go

x-pack/filebeat/input/cel/input_manager.go

michel-laterman

can you add comments to silence the linter (for errcheck)?

x-pack/libbeat/reader/parquet/parquet_test.go

Co-authored-by: Dan Kortschak <[email protected]>

khushijain21 · 2025-09-04T07:10:10Z

can you add comments to silence the linter (for errcheck)?

We are avoiding doing this here since the PR is already big. Maybe we can take it up in a separate issue

efd6

LGTM

There is no proposed commit message. Please don't just use the GitHub generated text from the eight commits here.

This PR accommodates breaking changes made in elastic-agent-libs . It effectively uses local logger in place of global ones (cherry picked from commit 0788d61) # Conflicts: # x-pack/filebeat/input/awss3/decoding_parquet.go # x-pack/filebeat/input/awss3/s3_objects.go # x-pack/filebeat/input/azureblobstorage/decoding.go # x-pack/filebeat/input/azureblobstorage/job.go # x-pack/filebeat/input/gcs/job.go

…ckage (#46426) * Accomodate logger changes from `tlscommon` package (#46308) This PR accommodates breaking changes made in elastic-agent-libs . It effectively uses local logger in place of global ones (cherry picked from commit 0788d61) # Conflicts: # x-pack/filebeat/input/awss3/decoding_parquet.go # x-pack/filebeat/input/awss3/s3_objects.go # x-pack/filebeat/input/azureblobstorage/decoding.go # x-pack/filebeat/input/azureblobstorage/job.go # x-pack/filebeat/input/gcs/job.go * fix conflict * fix ci --------- Co-authored-by: Khushi Jain <[email protected]>

…kage (#46427) * Accomodate logger changes from `tlscommon` package (#46308) This PR accommodates breaking changes made in elastic-agent-libs . It effectively uses local logger in place of global ones (cherry picked from commit 0788d61) # Conflicts: # x-pack/filebeat/input/awss3/decoding_parquet.go # x-pack/filebeat/input/awss3/s3_objects.go # x-pack/filebeat/input/azureblobstorage/decoding.go # x-pack/filebeat/input/azureblobstorage/job.go # x-pack/filebeat/input/gcs/job.go * fix conflicts * fix ci --------- Co-authored-by: Khushi Jain <[email protected]>

Accomodate logger changes from package

326bff8

khushijain21 requested review from a team as code owners August 29, 2025 07:26

khushijain21 requested review from AndersonQ and VihasMakwana August 29, 2025 07:26

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 29, 2025

khushijain21 requested review from kaanyalti and michel-laterman August 29, 2025 07:26

khushijain21 changed the title ~~Accomodate logger changes from package~~ Accomodate logger changes from tlscommon package Aug 29, 2025

mergify bot assigned khushijain21 Aug 29, 2025

khushijain21 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Aug 29, 2025

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 29, 2025

khushijain21 added needs_team Indicates that the issue/PR needs a Team:* label Team:Security-Service Integrations Security Service Integrations Team labels Aug 29, 2025

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 29, 2025

khushijain21 added needs_team Indicates that the issue/PR needs a Team:* label Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Aug 29, 2025

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 29, 2025

khushijain21 added Team:obs-ds-hosted-services Label for the Observability Hosted Services team needs_team Indicates that the issue/PR needs a Team:* label labels Aug 29, 2025

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 29, 2025

ishleenk17 approved these changes Aug 29, 2025

View reviewed changes

kaanyalti approved these changes Sep 1, 2025

View reviewed changes

efd6 reviewed Sep 1, 2025

View reviewed changes

x-pack/filebeat/input/cel/input_manager.go Outdated Show resolved Hide resolved

x-pack/filebeat/input/cel/input_test.go Show resolved Hide resolved

x-pack/libbeat/reader/parquet/parquet_test.go Outdated Show resolved Hide resolved

khushijain21 commented Sep 2, 2025

View reviewed changes

x-pack/filebeat/input/cel/input_manager.go Outdated Show resolved Hide resolved

Update x-pack/filebeat/input/cel/input_manager.go

019bff5

khushijain21 requested a review from efd6 September 2, 2025 04:39

khushijain21 added 2 commits September 2, 2025 10:09

Merge branch 'main' into localloggertls

3edb5f5

address review comment

d6dabfa

michel-laterman approved these changes Sep 3, 2025

View reviewed changes

efd6 reviewed Sep 3, 2025

View reviewed changes

x-pack/libbeat/reader/parquet/parquet_test.go Outdated Show resolved Hide resolved

Update x-pack/libbeat/reader/parquet/parquet_test.go

219b32c

Co-authored-by: Dan Kortschak <[email protected]>

khushijain21 requested a review from efd6 September 4, 2025 07:08

efd6 approved these changes Sep 4, 2025

View reviewed changes

AndersonQ approved these changes Sep 4, 2025

View reviewed changes

khushijain21 mentioned this pull request Sep 4, 2025

Replace global logger with local logger in tlscommon package elastic/elastic-agent-libs#348

Merged

3 tasks

khushijain21 added 2 commits September 5, 2025 15:27

Merge branch 'main' into localloggertls

019455f

update elastic-agent-libs

fbd0503

khushijain21 enabled auto-merge (squash) September 5, 2025 10:24

khushijain21 added backport-8.19 Automated backport to the 8.19 branch backport-9.1 Automated backport to the 9.1 branch labels Sep 5, 2025

khushijain21 added 2 commits September 8, 2025 08:58

Merge branch 'main' into localloggertls

350c2bf

Merge branch 'main' into localloggertls

5f91408

khushijain21 merged commit 0788d61 into elastic:main Sep 8, 2025
204 of 207 checks passed

This was referenced Sep 8, 2025

[8.19](backport #46308) Accomodate logger changes from tlscommon package #46426

Merged

[9.1](backport #46308) Accomodate logger changes from tlscommon package #46427

Merged

Accomodate logger changes from tlscommon package #46308

Accomodate logger changes from tlscommon package #46308

Uh oh!

Conversation

khushijain21 commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed commit message

Checklist

Related issues

Uh oh!

github-actions bot commented Aug 29, 2025

🤖 GitHub comments

Uh oh!

mergify bot commented Aug 29, 2025

Uh oh!

elasticmachine commented Aug 29, 2025

Uh oh!

elasticmachine commented Aug 29, 2025

Uh oh!

elasticmachine commented Aug 29, 2025

Uh oh!

elasticmachine commented Aug 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michel-laterman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

khushijain21 commented Sep 4, 2025

Uh oh!

efd6 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Accomodate logger changes from `tlscommon` package #46308

Accomodate logger changes from `tlscommon` package #46308

khushijain21 commented Aug 29, 2025 •

edited

Loading